Aseem - Phase 2 DOUBLE ACTION ITEM FIX - Add filters for Predicted vs Actual Cost Line chart and UI changes - #5403
Conversation
… and fixed dark mode compatibility
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kzou55
left a comment
There was a problem hiding this comment.
Hi Aseem,
I ran and tested the PR locally.
Verified
-
Start Date and End Date filters work
-
Reset filters work
Recording.2026-07-25.144523.mp4
-
Pie chart have numeric values and percentages on pie charts (Labor, Equipment, Materials).
-
Color overall seems consistent across the charts
Issues
- Only 1 project available in the project filter. Need more projects to fully test if the filter is working
- Filters(project, start date, end date, and reset) can be better aligned and same size.
Hello, Thank you for reviewing the task. CR1.mp4 |
kzou55
left a comment
There was a problem hiding this comment.
Hi Aseem,
I ran and tested the PR locally again.
Issues
-
The "Reset Filters" could be better aligned. Unless you intended for it to always be centered after main filter buttons. Personally found it to be taking up lots of unneeded spaces especially when it was full screen size as it looked like it could just be on the same line.
-
Start Date and End Date filter not fully working. Seems like anything before February 2026 and anything after July isn't getting rendered.
Recording.2026-07-27.234353.mp4
DeepighaJ
left a comment
There was a problem hiding this comment.
Tested the PR locally. Verified that the Project, Category, and Date filters function correctly, Reset/Clear Filters work as expected, tooltips display accurate and dynamically updated information, color mapping is consistent across charts, pie chart tooltips show amount and percentage, and the implementation works properly in dark mode.
Issues:
- In dark mode the date picker inputs remain white in Cost Breakdown by Category.
- Tooltip overlaps the donut in some cases.
Hi Deepigha, You are testing a different requirement. Please check the video for reference that I have uploaded to review this PR. Thanks! |
DeepighaJ
left a comment
There was a problem hiding this comment.
Tested the Financial Tracking and below are my observations.
@aseemdeshmukh according to your comment, the End Date should not allow selecting a date later than the current date. However, I was able to select an End Date of 10/01/2026, which appears to contradict the expected behavior. Could you please verify whether future End Dates should be restricted in the Calendar?

In the below snap i have selected start date in March but the x axis of chart starts from April, similarly if startdate in Feb, chart displays from March.


Pie chart displays as expected.



While testing the responsive/mobile layout, I observed that the chart tooltip flickers, making it difficult to read the values. Could you please confirm the tooltip hover behavior on smaller screen sizes? The hover area also seems quite small, affecting usability.

…art date and matches with the start date filter
|
|
DeepighaJ
left a comment
There was a problem hiding this comment.
Hi @aseemdeshmukh I see the future dates are disabled but today is 28th but i can see 29th still shown and I don't see the Feb month displaying in the x axis as shown in your screenshot.


Hi Deepigha, Please make sure to pull the latest commits as the issue that you have pointed has already been fixed. Also, please clear the cache and hard refresh the webpage. I have tested the issue again to confirm and attached a video below showing that I do not see any such issue from my end. CR3.mp4 |
There was a problem hiding this comment.
Hi Aseem,
I ran and tested the PR locally again.
Verified
- Filters(project, start date, end date) works
- Reset filter button works
- There are numeric values and percentages on pie charts (Labor, Equipment, Materials).
- Dark mode looks good
- Confirmed the changes implemented
Testing
-
Light Mode
Recording.2026-07-29.180406.mp4
-
Dark Mode
Recording.2026-07-29.181123.mp4
|
Thank you all, merging! |



















Replacement PR for PR #5375
Description
This PR covers/solves both of these similar tasks:

And also this task:
Related PRS (if any):
This frontend PR is related to the #4354 and #5375
Main changes explained:
How to test:
a) For dark mode, tooltips and texts are readable and can be distinguished --> * tooltip explanations for Planned, Actual, and Predicted costs exist
b) Filters for Projects and date filter work
c) reset filter button works
d) custom tooltip is working
e) There are numeric values and percentages on pie charts (Labor, Equipment, Materials).
f) Highlight cost overruns/underspends using color indicators or badges.
g) Ensure consistent color mapping across all charts (same color = same cost type).
Screenshots or videos of changes:
DemoAddFiltersFinancialTracking.mp4