Skip to content

replace bundled Lark adapter with new channel adapter#244

Merged
0xmrpeter merged 6 commits intoOpen-ACP:developfrom
redasm:main
Apr 28, 2026
Merged

replace bundled Lark adapter with new channel adapter#244
0xmrpeter merged 6 commits intoOpen-ACP:developfrom
redasm:main

Conversation

@redasm
Copy link
Copy Markdown

@redasm redasm commented Apr 28, 2026

Summary

Related Issues

Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 🔌 New adapter / plugin
  • 📝 Documentation
  • ♻️ Refactor (no functional change)
  • ⚡ Performance improvement
  • 🧪 Tests
  • 🔧 CI / Build / Config

Changes Made

Testing

  • Ran pnpm test — all tests pass
  • Tested manually with:
  • Added new tests for this change
  • No tests needed (explain why)

Platform Impact

  • Telegram
  • Discord
  • Slack
  • CLI
  • REST API
  • Web UI
  • All / Core

Screenshots / Recordings

Checklist

  • My code follows the project's TypeScript conventions (ESM, .js extensions)
  • I have updated relevant documentation (if needed)
  • I have added/updated tests (if applicable)
  • My changes don't introduce new warnings or errors
  • I have run pnpm build successfully
  • My changes are backward compatible with existing config and data formats
  • If changing plugin API / PluginContext: I have updated src/cli/plugin-template/

0xmrpeter and others added 6 commits April 24, 2026 13:41
Merges develop branch containing all changes since v2026.328.2.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: appleshu <appleshu@hack.com>
Co-authored-by: appleshu <appleshu@hack.com>
Adds a built-in Lark/Feishu adapter with setup wizard support, documentation, and tests so users can connect OpenACP through a self-built Lark bot over WebSocket. Also improves Windows package-runner resolution and makes the build script cross-platform.
@redasm redasm changed the title remove bundled Lark adapter replace bundled Lark adapter with new channel adapter Apr 28, 2026
@0xmrpeter
Copy link
Copy Markdown
Contributor

Thanks for the quick follow-up @strangeland — the cross-platform build script and Windows agent resolution fixes are exactly what we wanted from #241 without the bundled Lark code.

Two small things we noticed in agent-instance.ts — we'll handle those fixes for you on our end after merging:

  1. npx-cli.js path assumption — the check path.join(dir, "node_modules", "npm", "bin", "npx-cli.js") (where dir is dirname(process.execPath)) doesn't match the actual npm layout on macOS/Linux (npm lives in {noderoot}/lib/node_modules/, not next to the binary). The check always misses on non-Windows. Not a regression — it gracefully falls through — but effectively dead code on Mac/Linux.

  2. log.warn removed — the original warning when all candidate directories fail to resolve npx/uvx was useful for debugging user-reported "agent not found" issues. Without it, the fallback is silent.


One note for future contributions: please target the develop branch (not main) so your changes build on top of the latest in-progress work. We do main ← develop releases periodically.

Thanks again!

@0xmrpeter 0xmrpeter changed the base branch from main to develop April 28, 2026 02:34
@0xmrpeter 0xmrpeter merged commit c795897 into Open-ACP:develop Apr 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants