Skip to content

Conversation

@linxGnu
Copy link
Contributor

@linxGnu linxGnu commented Dec 29, 2025

cc @wing328
This PR update Rust-Axum Generator to include Host info without Host extractor. See also: tokio-rs/axum#3442

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Update the Rust-Axum generator to remove axum_extra::extract::Host and use headers::Host via TypedHeader in all handlers and traits. This keeps Host info available and aligns with axum’s Host extractor sunset.

  • Migration
    • Change handler params from Host to TypedHeader(Host).
    • Update traits and auth interfaces to use &headers::Host.
    • In Cargo.toml, add headers = "0.4" and enable axum-extra feature "typed-header".

Written for commit 12bf7e9. Summary will update automatically on new commits.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 94 files

Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.

@wing328 wing328 added this to the 7.19.0 milestone Dec 30, 2025
@wing328 wing328 merged commit 80be730 into OpenAPITools:master Dec 30, 2025
19 checks passed
@linxGnu linxGnu deleted the fix branch January 2, 2026 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants