[kotlin] Add integration test for query params #22588
Open
+71
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test for a regression from #22512 where param values were written as a list.
The test passes when the change to ApiClient.kt is reverted. Fails on the regression:
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)@karismann @Zomzog @andrewemery @4brunu @yutaka0m @stefankoppier @e5l
I did not run generators because it fails:
Summary by cubic
Adds Kotlin integration tests to verify query parameter encoding in the Spring RestClient and catch the regression from #22512 where values were wrapped as lists. Tests cover PetApi findByStatus (comma-separated list) and UserApi login (single values).
Written for commit 6767688. Summary will update automatically on new commits.