Skip to content

Conversation

@lucy66hw
Copy link
Contributor

@lucy66hw lucy66hw commented Dec 30, 2025

Copy the title field when creating the ArraySchema object in processNormalize31Spec()
#22591

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Preserves ArraySchema titles during OpenAPI 3.1 normalization so array schemas (e.g., in oneOf) keep their titles after processing.

  • Bug Fixes
    • Copy the title from the source schema to the created ArraySchema in processNormalize31Spec.
    • Add tests for OneOfArrayWithTitle to confirm titles are retained and the array type is preserved.

Written for commit e01ae0c. Summary will update automatically on new commits.

@lucy66hw lucy66hw marked this pull request as ready for review December 30, 2025 00:47
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@wing328 wing328 merged commit 873e272 into OpenAPITools:master Dec 30, 2025
15 checks passed
@wing328 wing328 added Issue: Bug OpenAPI Normalizer Normalize the spec for easier processing labels Dec 30, 2025
@wing328 wing328 added this to the 7.19.0 milestone Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue: Bug OpenAPI Normalizer Normalize the spec for easier processing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants