typescript axios enum generation bug with suffix#22754
typescript axios enum generation bug with suffix#22754jackdevis wants to merge 1 commit intoOpenAPITools:masterfrom
Conversation
…ion-based names for external ref schemas
|
thanks for the pr can you please write a test or 2 in https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/java/org/openapitools/codegen/InlineModelResolver.java to cover this change? |
7a2e79c to
a0751e5
Compare
a0751e5 to
3b3ae6e
Compare
|
cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10) @dennisameling (2026/02) |
dennisameling
left a comment
There was a problem hiding this comment.
@jackdevis I tested your changes against the schema in the reported issue, but it doesn't seem to fix it.
In that issue, I found a reference to an issue in the upstream swagger-parser which the openapi-generator uses, so I went ahead and created a PR with a fix there. Just reported back in the original issue that the fix there seems to resolve it. Shall we wait for that to be merged and see if it indeed fixes things?
Summary by cubic
Fixes incorrect model naming for $ref component schemas by using the referenced component name instead of operation-based names, resolving the axios enum suffix bug.
Written for commit 3b3ae6e. Summary will update on new commits.