Repository navigation
typescript-axios: support TypeScript 6 - #25148
Open
Felix-ming wants to merge 7 commits into
Open
Felix-ming wants to merge 7 commits into
Felix-ming wants to merge 7 commits into
Conversation
Add a regression assertion for the generated TypeScript dependency range.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply to a comment to ask cubic a question or push back. It learns from your replies.
Re-trigger cubic
Remove the explicit node10 moduleResolution override from generated ES6 tsconfig files. TypeScript 6 deprecates that setting; omitting it preserves the compiler default while keeping generated clients compatible.
Generate an ES6 client in the TypeScript 6 compatibility regression test and assert its tsconfig does not specify the deprecated node10 resolution option.
Member
|
thanks for the PR cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10) @KannaKim (2026/07) |
Remove 'moduleResolution' option from tsconfig.json
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typescript-axiosdevelopment dependency range.package.json.Closes #24830.
Validation
git diff --checkpassed../bin/generate-samples.sh ./bin/configs/typescript-axios-echo-api.yaml ./bin/configs/typescript-axios-es6-target.yaml; both generators succeeded../mvnw -pl modules/openapi-generator -am -Dtest=TypeScriptAxiosClientCodegenTest -Dsurefire.failIfNoSpecifiedTests=false test(15 tests, 0 failures). The latest PR workflow runs are awaiting maintainer approval.Prepared with AI assistance.
Summary by cubic
Expands the
typescript-axiosgenerated package's devDependency range to accept TypeScript 6 (^4.0 || ^5.0 || ^6.0), updates the sample clients accordingly, and removes the deprecatedmoduleResolution: nodeoverride from generated ES6tsconfigfiles so TypeScript 6 can use its compiler default. Adds a regression test asserting both the new dependency range and that the ES6 tsconfig omits the deprecated setting. Closes #24830.Written for commit 68a68c4. Summary will update on new commits.