[PATCH v3] api: crypto: add ZUC 256 algorithm#2335
[PATCH v3] api: crypto: add ZUC 256 algorithm#2335nkaithakadan wants to merge 1 commit intoOpenDataPlane:masterfrom
Conversation
odpbuild
changed the title
nkaithakadan
force-pushed
the
zuc_v2_spec
branch
from
1d8b848 to
99c4cfb
Compare
odpbuild
changed the title
|
@JannePeltonen Could you review these changes |
| * https://eprint.iacr.org/2021/1439 | ||
| */ | ||
| ODP_CIPHER_ALG_ZUC_EEA3, | ||
| ODP_CIPHER_ALG_ZUC_NEA6, |
There was a problem hiding this comment.
This change is not really adding a new algorithm in the API as the commit message says but just moves the currently defined 256-bit ZUC variant with 16-byte-IV from ODP_CIPHER_ALG_ZUC_EEA3 to ODP_CIPHER_ALG_ZUC_NEA6.
But, AFAIK, the algorithm defined in the referenced document is not exactly the same as NEA6 (unless things have recently changed), so adding a new algorithm name is fine, but it should not reference that document.
If we are adding ..._NEA6 and ..._NIA6 then maybe ..._NCA6 should be added too.
There was a problem hiding this comment.
Thanks Janne.
I am fine with removing the referenced document. I only mentioned it because it describes a ZUC‑256 variant with a 256‑bit key and a fixed 16‑byte IV.
Would you prefer that I remove the reference entirely ? And keep till Line number 181.
This change updates the API to expose the ZUC-256 16-byte IV variant using the proper NEA6/NIA6 identifiers instead of EEA3/EIA3. In addition, NCA6 is added to represent the combined confidentiality and integrity (AEAD) algorithm. Signed-off-by: Nithinsen Kaithakadan <[email protected]>
nkaithakadan
force-pushed
the
zuc_v2_spec
branch
from
99c4cfb to
1cd1130
Compare
odpbuild
changed the title
3 participants
Add ZUC256 cipher and integrity algorithm.