fix: Parse protobuf encoded keys for contract#226
Closed
manishdait wants to merge 2 commits intoOpenElements:mainfrom
Closed
fix: Parse protobuf encoded keys for contract#226manishdait wants to merge 2 commits intoOpenElements:mainfrom
manishdait wants to merge 2 commits intoOpenElements:mainfrom
Conversation
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
Contributor
Author
|
closing as repo get migrated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debugging the logs in https://github.com/OpenElements/hiero-enterprise-java/actions/runs/22081032269/job/63806078906?pr=224#step:7:538
failure is happening in
MirrorNodeJsonConverterImpl.toContract()at:_type = "ProtobufEncoded"is a serialized protobuf Key message. however,PublicKey.fromString()expects DER / raw Ed25519 / raw ECDSA formats. Passing protobuf serialized bytes causes parsing to fail internally causes the stacktrace.This PR fix the parsing of
admin_keyin toContract() forProtobufEncodedkey types.