Skip to content

chore: remove old systemd udev service - #196

Merged
luytan merged 1 commit into
mainfrom
remove-udev-settle
Aug 19, 2026
Merged

chore: remove old systemd udev service#196
luytan merged 1 commit into
mainfrom
remove-udev-settle

Conversation

@luytan

@luytan luytan commented Aug 19, 2026

Copy link
Copy Markdown
Member

Description

Remove the deprecated systemd-udev-settle.service
Fixes #195

TODO

  • Copy-Paste this line

Checklist:

  • My code follows the style guidelines of this project (cargo fmt)
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the mdBook documentation
  • My changes generate no new warnings (clippy/clang)
  • New and existing unit tests pass locally with my changes (either use nix flake check or wait for the ci)

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: bd86c5d5-6773-480e-87b7-76ebdae2d3b0

📥 Commits

Reviewing files that changed from the base of the PR and between 1d7222c and fe9513e.

📒 Files selected for processing (1)
  • assets/cardwired.service
💤 Files with no reviewable changes (1)
  • assets/cardwired.service

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Improved Cardwire service startup behavior by removing unnecessary service dependencies.
    • Cardwire now starts in the correct order relative to the system message bus.

Walkthrough

The Cardwire systemd unit no longer starts after systemd-udev-settle.service. It retains dbus.service as its only startup ordering dependency.

Changes

Cardwire service startup

Layer / File(s) Summary
Remove deprecated startup dependency
assets/cardwired.service
The unit removes the systemd-udev-settle.service dependency and retains ordering after dbus.service. This clears the deprecated invocation from the startup spell.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to fe951

This is a narrowly scoped service-file cleanup removing two lines; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the removal of the obsolete systemd udev service dependency.
Description check ✅ Passed The description includes the change summary, linked issue, template sections, and checklist.
Linked Issues check ✅ Passed The change removes the deprecated systemd-udev-settle.service dependency from cardwired.service as required by issue #195.
Out of Scope Changes check ✅ Passed The pull request changes only the relevant systemd dependency declarations and contains no unrelated modifications.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@luytan
luytan merged commit f5558f2 into main Aug 19, 2026
7 checks passed
@luytan
luytan deleted the remove-udev-settle branch August 19, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

systemd-udev-settle.service is deprecated

1 participant