🏗️🚮:drop the queue label's plain spelling - #1861
Merged
Merged
Conversation
The label is `🚀 Status: Commit Queue` now, so the plain name the condition also accepted no longer exists and nothing can carry it. The handbook names the label a reader has to apply, so it says the same. The condition is quoted whole: the name contains a colon, and an unquoted scalar reads that as a mapping. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5
✅ Deploy Preview for gh-pages-openinf ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
OpenINFbot
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The follow-up #1860 set up. The label is renamed, so the plain spelling
the condition also accepted is gone.
Done outside this branch
commit-queuewas renamed to🚀 Status: Commit Queuethrough the API.A rename rather than a create-and-delete, so it keeps its colour, its
description and anything carrying it:
Nothing carried it at the time, so nothing moved.
In here
contains a colon and an unquoted scalar reads that as a mapping
same thing
nps verify.yamlcaught the quoting: the first attempt at thecondition was an unquoted scalar and did not parse.
This is the pull request that tests it
Landing this one exercises the renamed label against the workflow that
merged in #1860, which is the last step that has not been proven yet.
If the queue does not pick it up, the condition on the base branch is
still the one accepting both names, so the old spelling would have to
be reinstated rather than anything being stuck.
Verified
github.event.label.name == '🚀 Status: Commit Queue'label named with an emoji, a space, a colon and an apostrophe
nps testpasses