Skip to content

🏗️🚮:drop the queue label's plain spelling - #1861

Merged
openinf-commit-queue[bot] merged 1 commit into
livefrom
chore/queue-label-rename
Aug 25, 2026
Merged

🏗️🚮:drop the queue label's plain spelling#1861
openinf-commit-queue[bot] merged 1 commit into
livefrom
chore/queue-label-rename

Conversation

@DerekNonGeneric

Copy link
Copy Markdown
Member

The follow-up #1860 set up. The label is renamed, so the plain spelling
the condition also accepted is gone.

Done outside this branch

commit-queue was renamed to 🚀 Status: Commit Queue through the API.
A rename rather than a create-and-delete, so it keeps its colour, its
description and anything carrying it:

$ gh api -X PATCH .../labels/commit-queue -f new_name='🚀 Status: Commit Queue'
🚀 Status: Commit Queue  #0e8a16  Land this pull request when its checks pass

$ gh api .../labels/commit-queue
{"message":"Not Found","status":"404"}

Nothing carried it at the time, so nothing moved.

In here

  • the condition matches the one name, quoted whole because the label
    contains a colon and an unquoted scalar reads that as a mapping
  • the handbook names the label a reader has to apply, so it says the
    same thing

nps verify.yaml caught the quoting: the first attempt at the
condition was an unquoted scalar and did not parse.

This is the pull request that tests it

Landing this one exercises the renamed label against the workflow that
merged in #1860, which is the last step that has not been proven yet.
If the queue does not pick it up, the condition on the base branch is
still the one accepting both names, so the old spelling would have to
be reinstated rather than anything being stuck.

Verified

  • the workflow parses, and the condition resolves to
    github.event.label.name == '🚀 Status: Commit Queue'
  • the removal step was run verbatim against the API in 🏗️♻️:let the queue label take either name #1860, on a
    label named with an emoji, a space, a colon and an apostrophe
  • nps test passes

The label is `🚀 Status: Commit Queue` now, so the plain name the
condition also accepted no longer exists and nothing can carry it. The
handbook names the label a reader has to apply, so it says the same.

The condition is quoted whole: the name contains a colon, and an
unquoted scalar reads that as a mapping.

Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
Assisted-by: Claude-Code:claude-opus-5
@netlify

netlify Bot commented Aug 25, 2026

Copy link
Copy Markdown

Deploy Preview for gh-pages-openinf ready!

Name Link
🔨 Latest commit 1d87097
🔍 Latest deploy log https://app.netlify.com/projects/gh-pages-openinf/deploys/6a8e09498754620008cc0701
😎 Deploy Preview https://deploy-preview-1861--gh-pages-openinf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@OpenINFbot OpenINFbot added the 🚀 Status: Commit Queue Land this pull request when its checks pass label Aug 25, 2026
@openinf-commit-queue
openinf-commit-queue Bot merged commit 0e7b922 into live Aug 25, 2026
15 checks passed
@openinf-commit-queue openinf-commit-queue Bot removed the 🚀 Status: Commit Queue Land this pull request when its checks pass label Aug 25, 2026
@OpenINFbot
OpenINFbot deleted the chore/queue-label-rename branch August 25, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants