Skip to content

Move the early exit in ?GESV for NRHS=0 after the GETRF call #5663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martin-frbg merged 1 commit into from
Mar 4, 2026
Merged

Move the early exit in ?GESV for NRHS=0 after the GETRF call #5663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions interface/lapack/gesv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ int NAME(blasint *N, blasint *NRHS, FLOAT *a, blasint *ldA, blasint *ipiv,

*Info = 0;

if (args.m == 0 || args.n == 0) return 0;
if (args.m == 0) return 0;

IDEBUG_START;

Expand All @@ -117,20 +117,20 @@ int NAME(blasint *N, blasint *NRHS, FLOAT *a, blasint *ldA, blasint *ipiv,

#if defined(_WIN64) && defined(_M_ARM64)
#ifdef COMPLEX
if (args.m * args.n <= 300)
if (args.m * args.m <= 300)
#else
if (args.m * args.n <= 500)
if (args.m * args.m <= 500)
#endif
args.nthreads = 1;
else if (args.m * args.n <= 1000)
else if (args.m * args.m <= 1000)
args.nthreads = 4;
else
args.nthreads = num_cpu_avail(4);
#else
#ifndef DOUBLE
if (args.m * args.n < 40000)
if (args.m * args.m < 40000)
#else
if (args.m * args.n < 10000)
if (args.m * args.m < 10000)
#endif
args.nthreads = 1;
else
Expand All @@ -143,7 +143,7 @@ int NAME(blasint *N, blasint *NRHS, FLOAT *a, blasint *ldA, blasint *ipiv,
args.n = *N;
info = GETRF_SINGLE(&args, NULL, NULL, sa, sb, 0);

if (info == 0){
if (info == 0 && *NRHS >0){
args.n = *NRHS;
GETRS_N_SINGLE(&args, NULL, NULL, sa, sb, 0);
}
Expand All @@ -154,7 +154,7 @@ int NAME(blasint *N, blasint *NRHS, FLOAT *a, blasint *ldA, blasint *ipiv,
args.n = *N;
info = GETRF_PARALLEL(&args, NULL, NULL, sa, sb, 0);

if (info == 0){
if (info == 0 && *NRHS > 0){
args.n = *NRHS;
GETRS_N_PARALLEL(&args, NULL, NULL, sa, sb, 0);
}
Expand Down
Loading