Skip to content

[com1]: time dependent release: allow multiple release features#1267

Open
PaulaSp3 wants to merge 1 commit intomasterfrom
PS_timeDepRel_multipleFeatures
Open

[com1]: time dependent release: allow multiple release features#1267
PaulaSp3 wants to merge 1 commit intomasterfrom
PS_timeDepRel_multipleFeatures

Conversation

@PaulaSp3
Copy link
Copy Markdown
Contributor

No description provided.

@PaulaSp3 PaulaSp3 requested review from awirb and fso42 April 29, 2026 16:59
@PaulaSp3 PaulaSp3 self-assigned this Apr 29, 2026
@PaulaSp3 PaulaSp3 added enhancement New feature or request DebrisFrame labels Apr 29, 2026
@qltysh
Copy link
Copy Markdown
Contributor

qltysh Bot commented Apr 29, 2026

Analysis for project AvaFrame

❌ 1 blocking issue (1 total)

Tool Category Rule Count
black Style Incorrect formatting, autoformat by running qlty fmt. 1

@qltysh one-click actions:

  • Auto-fix formatting (qlty fmt && git push)

@qltysh
Copy link
Copy Markdown
Contributor

qltysh Bot commented Apr 29, 2026

Qlty


Coverage Impact

This PR will not change total coverage.

Modified Components (1)

RatingComponent% Diff
Coverage rating: C Coverage rating: C
com1DFA50.0%

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
Coverage rating: B Coverage rating: B
avaframe/com1DFA/com1DFA.py50.0%480
Total50.0%
🤖 Increase coverage with AI coding...
In the `PS_timeDepRel_multipleFeatures` branch, add test coverage for this new code:

- `avaframe/com1DFA/com1DFA.py` -- Line 480

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

releaseLine["type"] = "time dependent Release"
timeDepRelValues, _ = gI.getTimeDepRelCsv(inputSimFiles["timeDepRelCsv"])
releaseLine["thickness"] = [timeDepRelValues["thickness"][timeDepRelValues["timeStep"] == 0].item()]
releaseLine["thickness"] = [
Copy link
Copy Markdown
Contributor

@fso42 fso42 May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the next line should also be extended, right?

If more than one release feature is present, geoTrans.prepareArea will raise an IndexError at
line["thicknessSource"][i] for i > 0 because the list has only one element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DebrisFrame enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants