F OpenNebula/engineering#730: Sunstone views role#176
Open
ArnauGabrielAtienza wants to merge 4 commits intoOpenNebula:masterfrom
Open
F OpenNebula/engineering#730: Sunstone views role#176ArnauGabrielAtienza wants to merge 4 commits intoOpenNebula:masterfrom
ArnauGabrielAtienza wants to merge 4 commits intoOpenNebula:masterfrom
Conversation
Signed-off-by: ArnauGabrielAtienza <[email protected]>
Collaborator
|
Is there any specific reason this has to be separate role? 🤔 |
Contributor
Author
|
Would it be better to include it as a task under the |
Member
|
I think best if we include it in the gui role, if @sk4zuzu agrees please @ArnauGabrielAtienza proceed |
Collaborator
|
@ArnauGabrielAtienza so I was thinking if you dont need this role to be reused anywhere else (and I suppose nobody does) I guess moving this code to gui role itself should be justified 🤔 |
Signed-off-by: ArnauGabrielAtienza <[email protected]>
Signed-off-by: ArnauGabrielAtienza <[email protected]>
Signed-off-by: ArnauGabrielAtienza <[email protected]>
Contributor
Author
|
@sk4zuzu Moved the role into a task inside the gui role. Please review. |
tinova
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New role that does the following:
/etc/one/fireedge/sunstone/views/sunstone-views.yaml