B #7588: apply iothread on virtio-blk disk hotplug#7593
Open
atodorov-storpool wants to merge 1 commit intoOpenNebula:masterfrom
Open
B #7588: apply iothread on virtio-blk disk hotplug#7593atodorov-storpool wants to merge 1 commit intoOpenNebula:masterfrom
atodorov-storpool wants to merge 1 commit intoOpenNebula:masterfrom
Conversation
atodorov-storpool
force-pushed
the
fix-disk-hotplug-iothread
branch
from
db271ac to
2caa091
Compare
The proposed patch handles a typo in the VM metadata parser. When the target is a `vd`(virtio-blk) disk: * Check are there iothreads defined for the domain. * If there is speciffic thread id defined for the disk * If no - the optional default attach virtio iothread id * check the values: use the max iothreads if the suggested iothread is bigger than the defined iothreads, or do not define if the suggested iothread is 0 or less.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The proposed patch handles a typo in the VM metadata parser.
Also, when the target is a
vd(virtio-blk) disk:Branches to which this PR applies