Repository navigation
feat(home): add Role Manager card + fix ecosystem toggle on /role-manager - #247
Merged
Merged
Conversation
Adds a fourth card to the Open Source Tools section of the docs homepage, linking to the Role Manager docs at /role-manager (matching Relayer, Monitor and UI Builder, which all point at their docs rather than their app). The supplied SVG hardcoded a #0A0A0A stroke, which would have been invisible in dark mode. The icon component uses currentColor instead, following the convention of the other icons in src/components/icons. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
/role-manager appears in both the Stellar and Ethereum & EVM navigation trees, so getEcosystemFromPath() treats it as ambiguous and returns null. But unlike the other cross-ecosystem pages (/monitor, /relayer, /ui-builder, /ecosystem-adapters, /tools) it was missing from the shared-path lists, and from every tab's `urls` set. The result: isTabActive() matched no tab on /role-manager, RootToggle's findLast() returned undefined, and the toggle fell back to its empty placeholder - the switcher rendered blank instead of showing the current ecosystem. Adds /role-manager to the shared-path checks and to the Ethereum and Stellar url sets, mirroring how /ui-builder is handled. The toggle now shows Ethereum & EVM by default, and stays on Stellar when the reader arrived from the Stellar docs. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
✅ Deploy Preview for openzeppelin-docs-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tirumerla
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two related changes around Role Manager:
/role-manager.1. Homepage card
/role-managerIt fills the empty second slot in the two-column Minor Tools grid next to UI Builder.
On the link target: the card points at the docs page rather than
rolemanager.openzeppelin.com, matching Relayer, Monitor and UI Builder, which all point at their docs. The Role Manager Quick Start links out to the app in its first section, so the app is one click away — and this keeps readers on the page whose toggle this PR repairs.On the icon: the supplied SVG hardcoded a
#0A0A0Astroke, which would have rendered near-invisible in dark mode.RoleManagerIconusescurrentColorand1emsizing instead, following the convention of the other icons insrc/components/icons/.2. Ecosystem toggle fix
/role-manageris listed in bothstellar.jsonandethereum-evm.json, sogetEcosystemFromPath()sees two owners, treats the page as ambiguous and returnsnull— by design.The problem is that
/role-managerwas then missing from the shared-path lists that handle exactly this case for/monitor,/relayer,/ui-builder,/ecosystem-adaptersand/tools, and from every tab'surlsset. So on/role-manager:isTabActive()matched no tab;RootToggle'sfindLast()returnedundefined;This adds
/role-managerto the shared-path checks inuse-navigation-tree.tsanddocs-layout-client.tsx, and to the Ethereum and Stellarurlssets — mirroring exactly how/ui-builderis already handled.Verification
biome checkon all changed files — clean.tsc --noEmit— clean./role-manageron a local dev server with and without the fix:href="/role-manager".Worth a reviewer's eye: the Stellar-context path (arrive at
/role-managerfrom the Stellar docs → toggle should stay on Stellar) is driven by client-sidesessionStorageand wasn't exercised by the SSR check above. The logic is identical to/ui-builder, but a manual click-through would confirm it.🤖 Generated with Claude Code