Migrate sortedset by OutSquareCapital · Pull Request #96 · OutSquareCapital/pyochain

OutSquareCapital · 2026-09-14T10:53:39Z

Confidence Score: 5/5

The PR appears safe to merge; no outstanding correctness issue or repository-rule violation was identified.

Summary

This PR migrates sorted-collection internals into reusable Rust crates and updates the PyO3 bindings, Python stubs, documentation, and regression coverage.

Separates empty operand lists from self-operands in sorted-set operations.
Preserves built-in set behavior for zero-argument and self-referential operations.
Adds typed regression tests for these cases.
Refactors shared PyO3 and standard-library utilities used by the migrated implementation.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
    Python["Python sorted collection API"] --> Bindings["PyO3 bindings"]
    Bindings --> Sorted["sorted_rs"]
    Sorted --> Core["Sorted collection storage and algorithms"]
    Bindings --> Ext["pyo3_ext helpers"]
    Sorted --> Tools["std_tools"]

_{Reviews (5) · Last reviewed commit: "fix: add `Args::Slf` to correctly handle..."}

…_rs`

- directly bind set accessors - make SetData generic on ListDataMethods

- added `tombi` to dev dependencies - added it to CI workflow - reformatted all files with it - adjusted CONTRIBUTING.md

fix false positives

impls

method

already available

move + simplify set cmp logic in sorted_rs

- aligned reprs of sorted lists with how objects are really constructed - deleted the duplicate`L` associated types, centralizing it in `ListGetter` - removed unneded duplication of `SetData` for `PyRepr` impls

unecessary (and truly unsafe) unsafe casts

pertinent

each iteration

enums architecture

already do, and who can then use this information and the sets mathematical properties to dispatch to the least expensive operation possible

for set operations. also allow to call these as methods directly on the pyclass, as well as factorizing a few bounds on SortedSetMethods

greptile-apps · 2026-09-22T18:19:24Z

Want your agent to iterate on Greptile's feedback? Try greploops.

handling `None` and `Slf` as the same operation)

OutSquareCapital added 30 commits September 10, 2026 02:51

refactor (WIP): start migration of sortedset inner structs to `sorted…

d48f91c

…_rs`

Merge branch 'dev' into migrate-sortedset

8f50956

fix: merge error

8d52a22

refactor:

4923e16

- directly bind set accessors - make SetData generic on ListDataMethods

fix: backtrack current changes to a compilable version to rethink impl

80fc72a

refactor: continue renaming standardisation

2e92dff

chore: add infos about IDE venv setup in CONTRIBUTING.md

827f14d

chore: changes related to last commit

aee8fa0

chore: reformat toml files with new formatter from Zed

86e8691

chore:

18204f8

- added `tombi` to dev dependencies - added it to CI workflow - reformatted all files with it - adjusted CONTRIBUTING.md

fix: added overloads to Iter::__new__, and related typing tests, to

65f5e41

fix false positives

chore: reformat markdowns file with markdown-oxide

32c5f6a

refactor: clean-up unecessary Sized bounds

9fe32b9

Update conversions.rs

0fce3d3

refactor: minor renaming changes

d97e3d7

refactor: move superfluous trait for set methods directly in the struct

164ba66

impls

feat: impl python iterators for SetData

312b9bd

refactor: finally migrated sorted sets logic in sorted_rs

2fffc1d

refactor: move some duplicated sorted dict methods in the base trait

485f16f

refactor: de-duplicate some code

b128c6e

refactor: add some overloads, avoid using itertools in tests

e6eaf2c

refactor: move views-related logic in pyo3_ext

b10772d

refactor: migrated dict methods to sorted_rs

40347fd

feat: add automatic implementation for py_abc when there's no required

3332df2

method

refactor: clean-up unecessary Python<'_> tokens when a Bound is

9a08998

already available

refactor: migrated a lot of logic from views to sorted_rs

ddf0d2d

feat: new ext method for Either

7ed33a4

refactor: continuation on logic migration to sorted_rs

a49bf59

refactor: move more code to sorted_rs

4cc8f16

refactor: move set wrapping logic in sorted_rs

c91a71b

OutSquareCapital added 24 commits September 21, 2026 12:06

chore: add command info to AGENTS.md

657aaec

refactor: replace InnerGetter traits by Deref + DerefMut

d7602e4

refactor: delete usage of ListDataOwner when not necessary

2ea5647

refactor: move macro impls in getters

c7e9441

refactor: reorganize sorted_rs folder to centralize structs declarations

b9243da

refactor: use and implemnt AsRef for MutexGuard obtention. allow to

821cb50

move + simplify set cmp logic in sorted_rs

refactor: move IntoUpdate constructor to sorted_rs

0e7cb65

refactor: reorganize PyRepr impls in a centralized module

6beff6c

chore: fix unused imports

d254933

refactor:

2045d13

- aligned reprs of sorted lists with how objects are really constructed - deleted the duplicate`L` associated types, centralizing it in `ListGetter` - removed unneded duplication of `SetData` for `PyRepr` impls

refactor: clean-up unneded code

004476f

refactor: add inline flags to iter tools

cc2fd64

refactor: codestyle changes in abc::PyoSet, as well as avoiding

bb4276d

unecessary (and truly unsafe) unsafe casts

fix: rename macros

3c91372

refactor: replace try_find_map by try_all and try_any when

e6ba181

pertinent

refactor: replace imperative for loop by try_any

a94ffd8

refactor: extracted some Arc/Mutex general code to std_tools

a7f0a0a

refactor: move extract_from to an associated func on SetData

58de4f3

refactor: renamed IntoUpdate to Args

16ee995

refactor: optimize discard ops in bulk to avoid rebinding the PySet at

3959760

each iteration

feat: added some doc related to set operations

8192bc2

refactor: fully fixed all deadlocks and incorrect computations, with new

513ace4

enums architecture

refactor: add a Args::None(py) variant to take advantage of checks we

7891e0d

already do, and who can then use this information and the sets mathematical properties to dispatch to the least expensive operation possible

refactor: added a trait to avoid long generic bounds at each call site

4b21ff7

for set operations. also allow to call these as methods directly on the pyclass, as well as factorizing a few bounds on SortedSetMethods

greptile-apps Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread crates/sorted_rs/src/set.rs Resolved

Comment thread tests/test_sorted.py Resolved

OutSquareCapital added 2 commits September 22, 2026 21:03

feat: add tests for empty args in set ops

ab0dd39

fix: add Args::Slf to correctly handle all set operations (avoid

7c783f1

handling `None` and `Slf` as the same operation)

OutSquareCapital merged commit 181300b into dev Sep 22, 2026
1 check passed

OutSquareCapital deleted the migrate-sortedset branch September 23, 2026 00:41

Navigation Menu

Repository navigation

Migrate sortedset - #96

Migrate sortedset#96
OutSquareCapital merged 129 commits into
devfrom
migrate-sortedset

OutSquareCapital commented Sep 14, 2026 •

edited by greptile-apps Bot

Loading

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot commented Sep 22, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

OutSquareCapital commented Sep 14, 2026 • edited by greptile-apps Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot commented Sep 22, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

OutSquareCapital commented Sep 14, 2026 •

edited by greptile-apps Bot

Loading