[DRAFT] Raven to SQL migration engine - #5851
Draft
warwickschroeder wants to merge 4 commits into
Draft
Conversation
rbev
reviewed
Sep 4, 2026
|
|
||
| - A third RavenDB lifecycle opens the source: connect, check the version, stop. It never calls `DatabaseSetup.Execute`. | ||
| - Both source databases must be on the same server or cluster (`LicensingDataStore.cs:35`). | ||
| - 🍅 The only version check that exists today compares the RavenDB server version to the RavenDB client version, and runs only for an external source. Nothing stamps a ServiceControl data version in the database, so refusing an unsupported source and naming the version to upgrade through is new work. |
Contributor
There was a problem hiding this comment.
We could actually enforce that they run at least once with the current version and stamp it into a document, refusing to run a migration until the version in that document matches.
That would make the step 1. Upgrade ServiceControl as normal, still on RavenDB. mandatory and make sure that customers jumping major versions don't bite us.
…d ServiceControl migration
…n, clarifying strategies, goals, and migration limitations.
warwickschroeder
force-pushed
the
warwick/spike-migration-engine
branch
from
September 11, 2026 06:05
3965754 to
f76ce9f
Compare
abparticular
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently only contains the high level raven to sql migration design (still in draft).