Stop the dismissed custom check test racing the endpoint's next report - #5875
Merged
Conversation
The test waited to observe the check gone from the API after dismissing it, but the endpoint reports every second, so the check is only ever absent for an instant and the poll regularly missed it. Six of the last nineteen Windows-Raven failures were this test stuck on that step. It now waits for the dismissal to be processed, observed through the CustomCheckDeleted domain event, and then for a report stamped after it, which proves the same thing without depending on timing.
ramonsmits
enabled auto-merge (squash)
September 9, 2026 15:53
danielmarbach
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should_come_back_while_the_check_is_still_failingaccounted for six of the last nineteen Windows-Raven failures, every time stuck on "Wait until it has gone". The endpoint reports every second, so after the dismissal the check is only ever absent for an instant and a poll cannot be expected to catch it.The test now waits for the dismissal to be processed, observed through the
CustomCheckDeleteddomain event with a handler registered viaCustomizeHostBuilder, and then for a report with aReportedAtlater than that. Same intent, no dependency on catching a transient state. Passes three runs in a row locally.