Conversation
rbev
changed the title
johnsimons
approved these changes
Sep 14, 2026
| // an index key serving sort=message_type. This field contains a type name, so it's more useful to | ||
| // truncate from the start of the name instead of the end. | ||
| static string? TruncateTypeName(string? value) => | ||
| value is { Length: > ColumnLengths.ShortTextLength } ? value[^ColumnLengths.ShortTextLength..] : value; |
Contributor
There was a problem hiding this comment.
Should we log this as a warning?
Member
There was a problem hiding this comment.
We can, but if a user reads that warning, what can they do?
Contributor
Author
There was a problem hiding this comment.
Also if their types are this long potentially it's going to log on every single error because their namespaces are out of control everywhere.
Contributor
There was a problem hiding this comment.
Hmm yeh thats true. Its something we doing that may surprise the user with no explanation. Maybe its worth something in documentation then. Also, could there be a situation where the truncation results in messages being incorrectly grouped?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5881 was auto merged, this PR contains the fixes requested from review.