Repository navigation
BridgeJS: Check thrown errors before lifting return values - #30
Merged
Merged
Conversation
krodak
force-pushed
the
kr/bridgejs-throw-before-lift
branch
from
November 3, 2026 00:59
4a290f6 to
835ee61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
An exported
throws(JSException)function that returns aJSObjector a@JSprotocol threwReferenceError: Attempted to use invalid reference 0in JavaScript instead of the Swift error. The generated glue lifted the return value before it checkedtmpRetException, so it read an object id that Swift never returned.The exception check now runs right after the
instance.exports.*call, before the lift:The second commit pins the example build jobs to
ubuntu-22.04.ubuntu-latestis now 26.04, whereapt-getcannot findlibgcc-9-devfor the ubuntu2204 toolchain.Testing
Added a throwing protocol return to the
Protocol.swiftsnapshot input and two runtime tests that throw from aJSObjectand a protocol return. Both runtime tests fail without the fix. BridgeJS snapshot tests andmake unittestpass.