Idolatry spirit walker ascendency support#2143
Closed
ltogniolli wants to merge 2 commits into
Closed
Conversation
Implement Idolatry (Spirit Walker) ascendancy mods Adds support for the three Idolatry notable mods: - Companions deal 10% increased damage per Idol in your Equipment - 2% increased Reservation Efficiency of Skills per Idol in your Equipment - -4% to all Elemental Resistances per non-Idol Augment in your Equipment CalcSetup now tallies socketed augments by type into IdolsInEquipment and NonIdolAugmentsInEquipment multipliers (only counting known augments, never empty sockets). ModParser gains the two "per idol/non-idol augment in your equipment" multiplier suffixes plus a companion-damage special case that reads the player count via actor = "parent". ModCache regenerated accordingly. @
Add Carved (Ancient Augment) Idols to socketable data Carved Cunning/Majesty/Mischief/Tenacity were never recognized because soulcore.txt had no #baseMatch for the Carved metadata prefix, so they were absent from ModRunes.lua. Add the directive and regenerate the data; these Idols now carry type = "Idol" with per-slot mod entries. @
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
add support to the idolatry spirit walker node and add carved ancient idols to the importer so idols are properly counted.
Steps taken to verify a working solution:
Unit Testing and in-pob verification
Link to a build that showcases this PR:
Before screenshot:
After screenshot: