Add support for Sinister Jewel sockets#2277
Open
followingthefasciaplane wants to merge 1 commit into
Open
Conversation
adds support for sinister jewel sockets granted by amulet anoints and Voices, including Zarokh's Gift. granted sockets now apply in calculator environments, update main build socket state only during the main calc pass, and are removed cleanly when the granting anoint/item goes away. also fixes the anoint picker so Zarokh's Gift appears by adding the new 0.5 emotions to the filter list, and verifies tooltip comparisons include jewels socketed into prospective Zarokh sockets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
intended to add support for sinister jewel sockets granted by Voices and Zarokh's Gift. granted sockets now apply in calculator environments, update main build socket state only during the main calc pass, and are removed cleanly when the granting anoint/item goes away.
also wanted to fix the anoint picker so Zarokh's Gift appears by adding the new 0.5 emotions to the filter list, and verify tooltip comparisons include jewels socketed.
dynamically adds or removes socketables from the items UI with persistent socket allocation
Steps taken to verify a working solution:
Screenshots