Fix gem level supports not working properly with some skills#2279
Open
LocalIdentity wants to merge 1 commit into
Open
Fix gem level supports not working properly with some skills#2279LocalIdentity wants to merge 1 commit into
LocalIdentity wants to merge 1 commit into
Conversation
Gem level supports were currently only applying their effect to the granted effect of the skill part that they matched. This causes issues when you have a skill like Apocalypse that has multiple granted effects Fire Mastery was only increasing the gem level for the meteor instead of the actual gem itself Now mods that use `SupportedGemProperty` apply to all the granted effects on a gem and go through their own loop We now have a `GemTag` mod type too that makes it easier to apply for future scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2202
Description of the problem being solved:
Gem level supports were currently only applying their effect to the granted effect of the skill part that they matched. This causes issues when you have a skill like Apocalypse that has multiple granted effects
Fire Mastery was only increasing the gem level for the meteor instead of the actual gem itself
Now mods that use
SupportedGemPropertyapply to all the granted effects on a gem and go through their own loopWe now have a
GemTagmod type too that makes it easier to apply for future scenariosLink to a build that showcases this PR:
https://pobb.in/2k0EPn6QOhTx
Before screenshot:
After screenshot: