Fix crash when importing some Djinn builds#2285
Closed
LocalIdentity wants to merge 1 commit into
Closed
Conversation
The skill Kelari's Deception assumed that we had a skill for it but it is a part of the minion as GGG handle the minion in a weird way We now make sure that the activeSkillList exists before looping through it
Contributor
|
Is this a complete fix? I tried this earlier and it didn't really seem to work. No skill means hovering over the 2nd selector (stat set i think?) causes a crash. Also, I noticed back then that reloading the build after avoiding the crash does make it appear 
|
Contributor
Author
|
Superceded by #2244 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2217
Description of the problem being solved:
The skill Kelari's Deception assumed that we had a skill for it but it is a part of the minion as GGG handle the minion in a weird way
We now make sure that the activeSkillList exists before looping through it
Link to a build that showcases this PR:
https://poe.ninja/poe2/profile/Kosmo2409-4451/runesofaldur/character/KozzieCull
Before screenshot:
After screenshot: