Skip to content

Add required stats filter to trader#2290

Open
vaisest wants to merge 5 commits into
PathOfBuildingCommunity:devfrom
vaisest:trader-stat-filters
Open

Add required stats filter to trader#2290
vaisest wants to merge 5 commits into
PathOfBuildingCommunity:devfrom
vaisest:trader-stat-filters

Conversation

@vaisest

@vaisest vaisest commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Fixes #471.

Description of the problem being solved:

Adds a UI which can be used to add an AND filter to the query. There are quite a few old issues about this in the pob1 repo. This is especially useful for e.g. spirit, filling attributes, or corrupted blood jewels in poe1

This also fixes an issue where a row didn't get cleared when results were empty.

Steps taken to verify a working solution:

  • All slots tested
  • Many modifiers tested

Link to a build that showcases this PR:

Before screenshot:

image

After screenshot:

Path.space.of.space.Building-PoE2_2026-06-25_19-11-58.mp4
image image

@vaisest vaisest marked this pull request as ready for review June 25, 2026 15:55
@vaisest

vaisest commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

I considered adding a NOT section that would blacklist some mods from having weights generated, but I can't really see this being comfortable to use. There are very few things that actually need it in rare gear, and I think it's probably mostly just cull which we might as well manually blacklist.

Megalomaniac have mods which inflate values for sure, but it would be quite uncomfortable to use. Manually editing the search and using price item is probably faster than doing the whole thing again, because it's likely you'll only realise it's giving you bad notables when you look at the results. It would also be more difficult to make a searchable list of the nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trader "Required Stats" option.

1 participant