Channeling skills now benefit from Spell Damage with Spells that cost Life mods#2293
Merged
LocalIdentity merged 3 commits intoJun 26, 2026
Conversation
LocalIdentity
approved these changes
Jun 26, 2026
LocalIdentity
merged commit 2836351
into
PathOfBuildingCommunity:dev
4 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2291 .
Description of the problem being solved:
Channeling skills are parsed as
LifePerSecondCostas opposedLifeCost. As all the life cost related conditions only accounted forLifeCost, related mods always evaluated the cost as 0.Steps taken to verify a working solution:
LifePerSecondCostModStore.lua'sstatListwhere the loop var conflicted the outer one. Renamed this (I don't really know why this works as I just renamed it after Pob started crashing)Link to a build that showcases this PR:
Before screenshot:
After screenshot: