Fix jewels socketed in gloves not importing correctly#2296
Open
LocalIdentity wants to merge 1 commit into
Open
Fix jewels socketed in gloves not importing correctly#2296LocalIdentity wants to merge 1 commit into
LocalIdentity wants to merge 1 commit into
Conversation
The Jewel is in the second socket of the item so the previous code would try to add the jewel to Gloves Jewel Socket 2 instead of socket 1 We now remove non jewel types from the index list incase GGG adds other jewel + rune combos in the future
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2294
Description of the problem being solved:
The Jewel is in the second socket of the item so the previous code would try to add the jewel to Gloves Jewel Socket 2 instead of socket 1
We now remove non-jewel types from the index list incase GGG adds other jewel + rune combos in the future
Link to a build that showcases this PR:
https://poe.ninja/poe2/builds/runesofaldur/character/thdxps-2023/Alduten?i=0&search=items%3DSylvan%2527s%2BEffigy
Before screenshot:
After screenshot: