Fix trader parsing everything as explicits - #10073
Merged
Wires77 merged 5 commits intoAug 1, 2026
Merged
Conversation
vaisest
force-pushed
the
fix-trader-item-parsing
branch
from
August 1, 2026 09:19
9f0861e to
fbc16b0
Compare
Wires77
approved these changes
Aug 1, 2026
Wires77
changed the title
Wires77
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This fixes item parsing for the trader. The problem is caused by GGG's provided item string having a weird format, and this instead builds a new string similarly to what PoB2 does.
Scourge mods not added here because I don't know how they work, they have a weird format, and they don't seem to be supported properly until #10039 is merged.
Depends on #10026
Steps taken to verify a working solution:
Link to a build that showcases this PR:
N/A
Before screenshot:
(everything parsed as explicits)
After screenshot: