Open
Conversation
Collaborator
|
Does this PR just create the empty structure? If so, I'm totally open to it, and I like the standalone class definition, though I wonder if "Scenario" is descriptive enough? (but then again, what is, right?). Otherwise, I'd be curious to learn more about how the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@anth-volk @PavelMakarchuk @MaxGhenis WDYT of this rough proposal.
Structural reforms have always been painful, and they are handled completely different than parametric reforms (and applying changes to the actual data is mostly impossible without modifying the simulation directly, e.g. increasing the earnings growth factor is impossible as a reform currently).
This
Scenarioclass could supersede the existing reform class, make those things all possible, and at the same time add stability, type checking, validation, etc. Happy to write docs etc but want to make sure this has buy-in first.