Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Preserve false debug and cache-refresh overrides when copying clients
Description:
Falsevalues fordebugandcache_force_refreshin bothPortkey.copy()andAsyncPortkey.copy(), including thewith_optionsaliases.Nonestill inherits the existing value.Motivation:
Portkey(cache_force_refresh=True).with_options(cache_force_refresh=False)currently still sendsx-portkey-cache-force-refresh: true, so a caller cannot disable forced refresh for a request. Debug overrides have the same issue. Theorexpressions discardFalse; selecting the existing value only forNonepreserves the override.Related Issues:
No existing issue found for these boolean overrides. This does not change HTTP-client defaults or the timeout work in #358/#403.
Verification:
pytest tests/test_client_copy.py -q: four request-header regressions fail on the unchanged base; all 16 cases pass with the fix, on Python 3.12.make formatandmake lint: passed, including mypy (144 source files), Black (171 files), and Ruff.git diff --check: passed.Tests exercise public chat-completion requests through HTTPX MockTransport. No provider calls, API credentials, or live integration tests were used. AI assistance: OpenAI Codex implementation and validation.