chore(code): gate unsafe cloud modes behind settings#1691
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 16, 2026
tatoalo
force-pushed
the
chore/code/cloud-mode-plumbing
branch
from
35e1b1c to
f07941b
Compare
tatoalo
force-pushed
the
chore/code/unsafe-mode-toggle-gating
branch
2 times, most recently
from
9570ec6 to
d615b72
Compare
tatoalo
force-pushed
the
chore/code/cloud-mode-plumbing
branch
from
f07941b to
032910a
Compare
tatoalo
force-pushed
the
chore/code/unsafe-mode-toggle-gating
branch
from
d615b72 to
8511fc1
Compare
tatoalo
force-pushed
the
chore/code/unsafe-mode-toggle-gating
branch
from
8511fc1 to
f30bfbe
Compare
tatoalo
force-pushed
the
chore/code/cloud-mode-plumbing
branch
from
032910a to
3aa8f3e
Compare
tatoalo
force-pushed
the
chore/code/unsafe-mode-toggle-gating
branch
from
f30bfbe to
8d77aed
Compare
tatoalo
force-pushed
the
chore/code/cloud-mode-plumbing
branch
from
3aa8f3e to
7d55f4d
Compare
tatoalo
force-pushed
the
chore/code/unsafe-mode-toggle-gating
branch
from
8d77aed to
027ea92
Compare
joshsny
approved these changes
Apr 16, 2026
| const { setShowRawLogs } = useSessionViewActions(); | ||
| const pendingPermissions = usePendingPermissionsForTask(taskId); | ||
| const modeOption = useModeConfigOptionForTask(taskId); | ||
| const { allowBypassPermissions } = useSettingsStore(); |
Contributor
There was a problem hiding this comment.
removing use effects, that's what it's all about
tatoalo
force-pushed
the
chore/code/cloud-mode-plumbing
branch
from
7d55f4d to
caa5d68
Compare
tatoalo
force-pushed
the
chore/code/unsafe-mode-toggle-gating
branch
from
027ea92 to
09aecab
Compare
tatoalo
force-pushed
the
chore/code/cloud-mode-plumbing
branch
2 times, most recently
from
67b2c19 to
48a73f3
Compare
tatoalo
force-pushed
the
chore/code/unsafe-mode-toggle-gating
branch
from
09aecab to
4299d06
Compare
tatoalo
changed the base branch from
chore/code/cloud-mode-plumbing
to
graphite-base/1691
tatoalo
force-pushed
the
graphite-base/1691
branch
from
48a73f3 to
536a163
Compare
tatoalo
force-pushed
the
chore/code/unsafe-mode-toggle-gating
branch
from
4299d06 to
e6a3654
Compare
tatoalo
force-pushed
the
chore/code/unsafe-mode-toggle-gating
branch
from
e6a3654 to
71c0489
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the existing settings toggle should control whether unsafe modes are exposed, but that policy should sit on top of the new (introduced in this stack) correct provider-specific mode plumbing.
This fixes also a UX/state updating consistency issue, hiding an unsafe mode must not rewrite or misreport the actual live session mode during reconnects.