Draft
Conversation
jc4042213
approved these changes
Feb 28, 2024
andyleejordan
force-pushed
the
main
branch
2 times, most recently
from
caa9e27 to
677f42c
Compare
If their value is available (either because its been set in the session manually, or the script has been executed or is being debugged) we can return it on the hover. We should ask if we actually want to do this, and if so, how we want to format it.
JustinGrote
force-pushed
the
andyleejordan/evaluate-hovers
branch
from
aaac8e1 to
0d49529
Compare
Collaborator
|
Sorry for the looong delay on looking at this. So my main concern here is snappiness. Because the LSP spec only has a single hover request and reply, running the evaluate through the pipeline delays the hover by a lot. If we had a refresh mechanism like inlay, that wouldn't be an issue (requested here) So I think we should keep "fast" out of band hovers as much as possible to keep things snappy, but more detailed hovers that require a pipeline request would have to be setting opt-in as they would be slower to produce (we can report using the progress token as well as cache responses for things like help) until we had a streaming approach. |
Collaborator
|
Example (builtin function def) vs Variable. 3ms vs 300ms |
andyleejordan
force-pushed
the
main
branch
2 times, most recently
from
80b2351 to
9ce8911
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If their value is available (either because its been set in the session manually, or the script has been executed or is being debugged) we can return it on the hover.
We should ask if we actually want to do this, and if so, how we want to format it.
@JustinGrote try this out!
Fixes PowerShell/vscode-powershell#4878.