Skip to content

Fix/remove duplicate footer links 2799#2800

Open
desireddymohithreddy0925 wants to merge 10 commits into
Priyanshu-byte-coder:mainfrom
desireddymohithreddy0925:fix/remove-duplicate-footer-links-2799
Open

Fix/remove duplicate footer links 2799#2800
desireddymohithreddy0925 wants to merge 10 commits into
Priyanshu-byte-coder:mainfrom
desireddymohithreddy0925:fix/remove-duplicate-footer-links-2799

Conversation

@desireddymohithreddy0925

Copy link
Copy Markdown
Contributor

Summary

Fixes the Footer component by removing the redundant hardcoded "Product" navigation links. The "Dashboard" authentication logic has been moved inside the PRODUCT_LINKS mapped loop to prevent duplicated links while preserving functionality.

Closes #2799


Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that changes existing behavior)
  • 📝 Documentation update
  • ♻️ Refactor / code cleanup (no functional change)
  • ⚡ Performance improvement
  • 🔒 Security fix
  • 🧪 Tests only

What Changed

  • src/components/Footer.tsx: Removed the hardcoded duplicate block of "Home", "Dashboard", "Leaderboard", and "Contact" links.
  • src/components/Footer.tsx: Updated FooterLink component to support the onClick prop, rendering a stylistically identical <button> instead of a <Link> when provided.
  • src/components/Footer.tsx: Intercepted the "Dashboard" iteration in the PRODUCT_LINKS.map loop to trigger the GitHub signIn action if the user is unauthenticated, replicating the old functionality cleanly.

How to Test

  1. Check out the branch and run the development server (npm run dev).
  2. Navigate to the homepage or dashboard while unauthenticated and scroll down to the Footer.
  3. Observe that the Product section has exactly one set of links (Home, Dashboard, Leaderboard, Contact).
  4. Click on the "Dashboard" link and ensure it triggers the GitHub authentication redirect.
  5. Log in (authenticate) and verify the "Dashboard" link in the footer routes to /dashboard directly without triggering auth again.

Expected result:
The footer looks clean without duplicated links, and unauthenticated users can click "Dashboard" to sign in successfully.


Screenshots / Recordings

Before After
(Duplicate Home, Dashboard, Leaderboard, and Contact) (Clean, single list of 4 links)

Checklist

  • Linked the related issue above
  • Self-reviewed my own diff
  • No unnecessary console.log, debug code, or commented-out blocks
  • npm run lint passes locally
  • No TypeScript errors (npm run type-check)
  • Added or updated tests where applicable
  • Updated documentation / comments if behavior changed

Accessibility (UI changes only)

  • Keyboard navigation works correctly (the <button> respects focus-visible)
  • Color contrast meets WCAG AA standard
  • ARIA labels / roles added where needed
  • Tested on mobile / responsive layout

Additional Context

N/A

@github-actions github-actions Bot added type:bug GSSoC type bonus: bug fix type:feature GSSoC type bonus: new feature type:testing GSSoC type bonus: tests (+10 pts) type:design GSSoC type bonus: UI/design (+10 pts) type:performance GSSoC type bonus: performance (+15 pts) gssoc26 GSSoC 2026 contribution labels Jun 25, 2026
@github-actions

Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Priyanshu-byte-coder — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

@desireddymohithreddy0925 desireddymohithreddy0925 changed the title Fix/remove duplicate footer links 2799 Fix: remove duplicate footer links 2799 Jun 25, 2026
@desireddymohithreddy0925 desireddymohithreddy0925 changed the title Fix: remove duplicate footer links 2799 Fix/remove duplicate footer links 2799 Jun 25, 2026
@github-actions github-actions Bot added the type:devops GSSoC type bonus: devops (+15 pts) label Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc26 GSSoC 2026 contribution type:bug GSSoC type bonus: bug fix type:design GSSoC type bonus: UI/design (+10 pts) type:devops GSSoC type bonus: devops (+15 pts) type:feature GSSoC type bonus: new feature type:performance GSSoC type bonus: performance (+15 pts) type:testing GSSoC type bonus: tests (+10 pts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Remove duplicate navigation links from the footer

1 participant