Fix/remove duplicate footer links 2799#2800
Open
desireddymohithreddy0925 wants to merge 10 commits into
Open
Conversation
…vent dashboard crash
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
…footer-links-2799
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Footer component by removing the redundant hardcoded "Product" navigation links. The "Dashboard" authentication logic has been moved inside the
PRODUCT_LINKSmapped loop to prevent duplicated links while preserving functionality.Closes #2799
Type of Change
What Changed
src/components/Footer.tsx: Removed the hardcoded duplicate block of "Home", "Dashboard", "Leaderboard", and "Contact" links.src/components/Footer.tsx: UpdatedFooterLinkcomponent to support theonClickprop, rendering a stylistically identical<button>instead of a<Link>when provided.src/components/Footer.tsx: Intercepted the "Dashboard" iteration in thePRODUCT_LINKS.maploop to trigger the GitHubsignInaction if the user is unauthenticated, replicating the old functionality cleanly.How to Test
npm run dev)./dashboarddirectly without triggering auth again.Expected result:
The footer looks clean without duplicated links, and unauthenticated users can click "Dashboard" to sign in successfully.
Screenshots / Recordings
Checklist
console.log, debug code, or commented-out blocksnpm run lintpasses locallynpm run type-check)Accessibility (UI changes only)
<button>respectsfocus-visible)Additional Context
N/A