fix(viem): omit missing typed-data chainId - #1995
Open
omerbek wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
domain.chainIdintoNaNin the viem signer adapterundefinedwhenchainIdis absent, matching the optional handling used by the viem seaport bridgechainIdin the domainFixes #1994.
Testing
npm run test -- test/provider/viem-adapter.spec.tsnpm run check-typesnpx biome check src/provider/viem-adapter.ts test/provider/viem-adapter.spec.tsAdditional local notes:
npm cicurrently fails becausepackage.jsonandpackage-lock.jsonare out of sync onmain(eslint@10.8.1and transitive deps missing from the lockfile). I usednpm install --package-lock=falsefor local verification without changing the lockfile.npm run testreports 39 passed test files / 858 passed tests, then exits non-zero due to two unhandledERR_REQUIRE_ESMerrors from@asamuzakjp/css-colorrequiring@csstools/css-calcunder the local Node v21.6.1 environment. The targeted viem adapter test passes.npm run lintreports existing repository-wide CRLF formatting differences; the two changed files passnpx biome checkdirectly.