Add folder-based split tunneling support#116
Open
xacnio wants to merge 1 commit intoProtonVPN:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Some applications may have dynamic .exe paths, so app-based split tunneling alone is not enough.
For example: When Discord released an update, the app path changes
"app-1.0.9228"->"app-1.0.9229"\Discord\app-1.0.9228\Discord.exe-->\Discord\app-1.0.9229\Discord.exe"It forces us to re-add the application and re-connect vpn every time it updates.
Solution
Folder-based split tunneling.
Risks
» Up to the user, possible client-side performance issues.
»
No constraints applied.» FileSystemWatcher may encounter issues.
»
Folder count is limited to 50.