build: add dependencies cooldown#660
Conversation
begumcig
left a comment
There was a problem hiding this comment.
Not deny not approve but a secret third thing (a question)
|
|
||
| [tool.uv] | ||
| index-strategy = "first-index" | ||
| exclude-newer = "1 week" # protection against compromised dependencies |
There was a problem hiding this comment.
what do we mean by compromised here? Are we getting the all newer packages with a delay regardless?
There was a problem hiding this comment.
Yes, this is to avoid getting versions where the compromission isn't already identified.
For those which are identified as poisonned, if the patch isn't shipped in 1 week we can pin the max versions that is safe to use.
There was a problem hiding this comment.
Exactly as Amine said, "compromised" here means that there may be a security issue with the latest version of one of the dependencies. If this is the case, the cooldown introduces a 1 week delay giving the community time to spot it and patch it, or giving us the possibility to pin the version to a non-compromised one if the patch is not available after this one week period
Description
This PR adds a 1 week cooldown for dependencies to protect against compromised packages. This gives us a 1 week delay to get any news about compromised packages and
Related Issue
Fixes #(issue number)
Type of Change
How Has This Been Tested?
I checked the uv pip install behavior for torch 2.11 dating back from march 23 (<2 months ago) with a no filter (is the version selected), 1 week filter (no change), 8 weeks filter (torch 2.10 is selected instead).
Checklist
Additional Notes