206 i command return protocol version #305
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBakedPotato
force-pushed
the
273-move-to-platformio
branch
from
14e4d4d to
12e6cb8
Compare
TheBakedPotato
force-pushed
the
206-i-command-return-protocol-version
branch
from
c79c4bc to
7084f89
Compare
TheBakedPotato
force-pushed
the
273-move-to-platformio
branch
2 times, most recently
from
b74c930 to
cd2497a
Compare
TheBakedPotato
force-pushed
the
206-i-command-return-protocol-version
branch
from
7084f89 to
d33c773
Compare
- GPAD_API_VERSION is now defined as a preprocessor directive, like FIRMWARE_VERSION - The value is published via MQTT just like the FIRMWARE_VERSION
…ment - The GPAD API version is now hardcoded as an actual value - It is not something that should be able to be changed by a compilation flag
TheBakedPotato
force-pushed
the
206-i-command-return-protocol-version
branch
from
acc73aa to
ae6b969
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
icommand for the GPAD API now returns the version of the GPAD API itself.Instead of using a preprocessor directive for the version value, it is now an actual member of the new
GPAD_APIclass. This class, while very bare at the moment, can also be used to better contain the the methods/functionality inside thegpad_hal.h/csource files.