Skip to content

Render every speaker for co-hosted keynote sessions#261

Merged
JacobCoffee merged 1 commit intomainfrom
fix/keynote-multi-speaker
Apr 18, 2026
Merged

Render every speaker for co-hosted keynote sessions#261
JacobCoffee merged 1 commit intomainfrom
fix/keynote-multi-speaker

Conversation

@JacobCoffee
Copy link
Copy Markdown
Member

@JacobCoffee JacobCoffee commented Apr 18, 2026

Summary

Session detail pages for co-hosted keynote sessions (e.g. "Rachell Calhoun & Tim Schilling") were only showing one speaker. The enrichment loop stopped at the first matching keynote speaker in `keynoteSpeakers`:

for (const [name, data] of Object.entries(this.keynoteSpeakers)) {
  if (sessionName.toLowerCase().includes(name.toLowerCase())) {
    this.keynoteData = { name, ...data };
    break;  // <- only the first hit
  }
}

For the Sun 3:15 pm slot, iteration hit Tim Schilling first, set `keynoteData` to Tim, and broke — Rachell Calhoun never made it to the template.

Fix

  • `keynoteData` is now an array of every matching keynote speaker.
  • Template `ngFor`s the speaker card so all matches render.

Test plan

  • Rachell Calhoun & Tim Schilling session detail — both speaker cards render
  • Single-speaker keynote sessions (Lin Qiao, amanda casari, Pablo Galindo Salgado) still render one card
  • Non-keynote sessions unchanged

The keynote-speaker enrichment loop broke after the first matching entry,
so a shared keynote like "Rachell Calhoun & Tim Schilling" only rendered
one of the two on the session detail page.

Switch keynoteData to an array, collect every keynote speaker whose name
appears in the session title, and ngFor the speaker card template.
@JacobCoffee
Copy link
Copy Markdown
Member Author

image

@JacobCoffee JacobCoffee enabled auto-merge (squash) April 18, 2026 05:37
@JacobCoffee JacobCoffee disabled auto-merge April 18, 2026 05:37
@JacobCoffee JacobCoffee merged commit ae05723 into main Apr 18, 2026
2 checks passed
@JacobCoffee JacobCoffee deleted the fix/keynote-multi-speaker branch April 18, 2026 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant