refactor(voice): Rewrite Voice Internals & DAVE Support#2873
Draft
DA-344 wants to merge 55 commits intoPycord-Development:masterfrom
Draft
refactor(voice): Rewrite Voice Internals & DAVE Support#2873DA-344 wants to merge 55 commits intoPycord-Development:masterfrom
DA-344 wants to merge 55 commits intoPycord-Development:masterfrom
Conversation
…344/pycord into feat/voice-rewrite-and-fixes
…344/pycord into feat/voice-rewrite-and-fixes
…344/pycord into feat/voice-rewrite-and-fixes
DA-344
changed the title
…344/pycord into feat/voice-rewrite-and-fixes
DA-344
force-pushed
the
feat/voice-rewrite-and-fixes
branch
from
c461cbf to
a324844
Compare
Paillat-dev
added
priority: medium
Paillat-dev
added
priority: high
Member
This is completely fine for the record, but make sure to update the license on top of the file if substantial portions of code are taken from there. Also, I pushed a couple small fixes to make CI pass, feel free to force push if they conflict w/anything you have locally |
Paillat-dev
changed the title
DA-344
force-pushed
the
feat/voice-rewrite-and-fixes
branch
from
d565ce5 to
bcc841d
Compare
DA-344
changed the title
Paillat-dev
reviewed
Feb 28, 2026
| @@ -0,0 +1,8 @@ | |||
| from .reader import AudioReader | |||
Paillat-dev
reviewed
Feb 28, 2026
|
|
||
|
|
||
| <<<<<<< HEAD | ||
| def deprecated( |
Paillat-dev
reviewed
Feb 28, 2026
|
|
||
| Events | ||
| ------ | ||
| These section outlines all the available sink events. |
Paillat-dev
reviewed
Feb 28, 2026
| __all__ = ("VoiceProtocol", "VoiceClient") | ||
|
|
||
|
|
||
| if TYPE_CHECKING: |
Member
There was a problem hiding this comment.
Instead of this could just import inside the method. Would be clearer imo ? Wdyt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If you don't want your code to explode or something similar, don't use this PR, thanks. ;)
WIP.
A rewrite to its internals to fix various things.
I don't expect this to be merged on 2.7, so it should not block it
This is partially inspired on discord.py's voice code & imayhaveborkedit/voice-recv
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.Related
Fixes #2833