Skip to content

fix: remove internal use of deprecated suppress#3154

Merged
Lulalaby merged 5 commits intoPycord-Development:masterfrom
Revnoplex:fix/internal-deprecation-warnings
Mar 16, 2026
Merged

fix: remove internal use of deprecated suppress#3154
Lulalaby merged 5 commits intoPycord-Development:masterfrom
Revnoplex:fix/internal-deprecation-warnings

Conversation

@Revnoplex
Copy link
Contributor

@Revnoplex Revnoplex commented Mar 16, 2026

Summary

#3062 deprecated the use of suppress in favour of suppress_embeds but not all usages were removed internally leading to internally caused deprecation warnings. This pr removes usages of suppress and adds suppress_embeds as a parameter as needed to stop these warnings happening internally.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.
  • AI Usage has been disclosed.
    • If AI has been used, I understand fully what the code does

@pycord-app
Copy link

pycord-app bot commented Mar 16, 2026

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3154/head:pr-3154
git checkout pr-3154

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3154/head

Copy link
Member

@Paillat-dev Paillat-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR !

Revnoplex and others added 3 commits March 16, 2026 23:47
Co-authored-by: Paillat <jeremiecotti@ik.me>
Signed-off-by: Revnoplex <62947003+Revnoplex@users.noreply.github.com>
@Paillat-dev
Copy link
Member

@Revnoplex Since the original PR hasn't been released yet you can omit the changelog, it has one already concerning the deprecation

@Paillat-dev Paillat-dev added bug Something isn't working priority: low Low Priority labels Mar 16, 2026
Copy link
Member

@Paillat-dev Paillat-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ltgm; thx

@Lulalaby Lulalaby merged commit 4498ae5 into Pycord-Development:master Mar 16, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority: low Low Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants