feat(new-nav): add "Terraform configuration" settings section#2540
feat(new-nav): add "Terraform configuration" settings section#2540rmnbrd merged 7 commits intonew-navigationfrom
Conversation
|
Qovery can create a Preview Environment for this PR.
This comment has been generated from Qovery AI 🤖.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## new-navigation #2540 +/- ##
=================================================
Coverage ? 44.64%
=================================================
Files ? 1054
Lines ? 21350
Branches ? 6288
=================================================
Hits ? 9532
Misses ? 10086
Partials ? 1732
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds a new “Terraform configuration” settings page/section (console-v5 route + shared settings UI), and refactors/re-exports related Terraform utilities/components while aligning some shared UI styling.
Changes:
- Adds the new console-v5
terraform-configurationsettings route with form wiring and save handling. - Moves/consumes Terraform configuration UI + helper utilities from
@qovery/domains/service-settings/featureand reworks Terraform domain exports (hook rename, inline setting export changes). - Updates shared UI styling for inline code editor empty states and icon-only edit button.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/shared/ui/src/lib/components/code-editor-inline-setting/code-editor-inline-setting.tsx | Makes the edit button icon-only and updates empty-state colors. |
| libs/pages/application/src/lib/feature/page-settings-terraform-configuration-feature/page-settings-terraform-configuration-feature.tsx | Switches Terraform configuration page to use service-settings feature exports. |
| libs/domains/service-terraform/feature/src/lib/terraform-variables-settings/terraform-variables-context.tsx | Adjusts imports for Terraform general form typing. |
| libs/domains/service-terraform/feature/src/lib/terraform-variables-settings/dockerfile-fragment-inline-setting/dockerfile-fragment-inline-setting.tsx | Removes default export. |
| libs/domains/service-terraform/feature/src/lib/terraform-variables-settings/dockerfile-fragment-inline-setting/dockerfile-fragment-inline-setting.spec.tsx | Updates imports + adds TanStack router mocks for tests. |
| libs/domains/service-terraform/feature/src/lib/terraform-variables-settings/dockerfile-fragment-inline-setting/snapshots/dockerfile-fragment-inline-setting.spec.tsx.snap | Updates snapshots for new button/icon styles and colors. |
| libs/domains/service-terraform/feature/src/lib/hooks/use-terraform-available-versions/use-terraform-available-versions.ts | Renames hook to plural and removes default export. |
| libs/domains/service-terraform/feature/src/index.ts | Updates barrel exports (adds hook + inline setting export; removes prior export). |
| libs/domains/service-settings/feature/src/lib/terraform-configuration-settings/terraform-configuration-settings.ui.spec.tsx | Updates mocks to use service-terraform feature hook export. |
| libs/domains/service-settings/feature/src/lib/terraform-configuration-settings/terraform-configuration-settings.tsx | Uses Terraform hook + inline setting from service-terraform; updates UI and modal content structure. |
| libs/domains/service-settings/feature/src/lib/terraform-configuration-settings/terraform-configuration-settings.spec.ts | Adds unit tests for dockerfile fragment helper utilities. |
| libs/domains/service-settings/feature/src/index.ts | Exposes TerraformConfigurationSettings module from service-settings feature. |
| libs/domains/service-helm/feature/src/lib/values-override-yaml-setting/snapshots/values-override-yaml-setting.spec.tsx.snap | Snapshot updates for empty-state color token changes. |
| libs/domains/service-helm/feature/src/lib/values-override-files-setting/snapshots/values-override-files-setting.spec.tsx.snap | Snapshot updates for empty-state color token changes. |
| apps/console-v5/src/routes/_authenticated/.../settings/terraform-configuration.tsx | Implements the new console-v5 Terraform configuration settings route with Suspense + form submission. |
Comments suppressed due to low confidence (1)
libs/domains/service-settings/feature/src/lib/terraform-configuration-settings/terraform-configuration-settings.tsx:370
Modaltrigger usesLinkwithout the requiredto/paramsprops.@qovery/shared/ui'sLinkwraps TanStack Router'sLink(seeLinkProps), so this will be a TypeScript error and is also semantically wrong for a non-navigation action. Use abutton/Buttonfor the trigger, or useLinkwithas="button"only if you also provide a validto(navigation).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
PR adding the "Terraform configuration" settings section
Screenshots / Recordings
https://www.loom.com/share/f7d27c164ac64fad828ebddaab570748