Skip to content

feat(new-nav): add "Terraform configuration" settings section#2540

Merged
rmnbrd merged 7 commits intonew-navigationfrom
feat/new-nav/terraform-configuration-settings
Mar 26, 2026
Merged

feat(new-nav): add "Terraform configuration" settings section#2540
rmnbrd merged 7 commits intonew-navigationfrom
feat/new-nav/terraform-configuration-settings

Conversation

@rmnbrd
Copy link
Contributor

@rmnbrd rmnbrd commented Mar 25, 2026

Summary

PR adding the "Terraform configuration" settings section

Screenshots / Recordings

https://www.loom.com/share/f7d27c164ac64fad828ebddaab570748

@RemiBonnet
Copy link
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 15d69f24-9bc1-4a8d-80fe-d1bb1b2bcd00 New Navigation
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Don’t Sacrifice Readability, you are going to debug it in 6 months

@rmnbrd rmnbrd added the V5 label Mar 25, 2026
@rmnbrd rmnbrd self-assigned this Mar 25, 2026
@codecov
Copy link

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (new-navigation@22e853e). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2540   +/-   ##
=================================================
  Coverage                  ?   44.64%           
=================================================
  Files                     ?     1054           
  Lines                     ?    21350           
  Branches                  ?     6288           
=================================================
  Hits                      ?     9532           
  Misses                    ?    10086           
  Partials                  ?     1732           
Flag Coverage Δ
unittests 44.64% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rmnbrd rmnbrd requested a review from RemiBonnet March 26, 2026 09:38
@rmnbrd rmnbrd marked this pull request as ready for review March 26, 2026 09:38
Copilot AI review requested due to automatic review settings March 26, 2026 09:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new “Terraform configuration” settings page/section (console-v5 route + shared settings UI), and refactors/re-exports related Terraform utilities/components while aligning some shared UI styling.

Changes:

  • Adds the new console-v5 terraform-configuration settings route with form wiring and save handling.
  • Moves/consumes Terraform configuration UI + helper utilities from @qovery/domains/service-settings/feature and reworks Terraform domain exports (hook rename, inline setting export changes).
  • Updates shared UI styling for inline code editor empty states and icon-only edit button.

Reviewed changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
libs/shared/ui/src/lib/components/code-editor-inline-setting/code-editor-inline-setting.tsx Makes the edit button icon-only and updates empty-state colors.
libs/pages/application/src/lib/feature/page-settings-terraform-configuration-feature/page-settings-terraform-configuration-feature.tsx Switches Terraform configuration page to use service-settings feature exports.
libs/domains/service-terraform/feature/src/lib/terraform-variables-settings/terraform-variables-context.tsx Adjusts imports for Terraform general form typing.
libs/domains/service-terraform/feature/src/lib/terraform-variables-settings/dockerfile-fragment-inline-setting/dockerfile-fragment-inline-setting.tsx Removes default export.
libs/domains/service-terraform/feature/src/lib/terraform-variables-settings/dockerfile-fragment-inline-setting/dockerfile-fragment-inline-setting.spec.tsx Updates imports + adds TanStack router mocks for tests.
libs/domains/service-terraform/feature/src/lib/terraform-variables-settings/dockerfile-fragment-inline-setting/snapshots/dockerfile-fragment-inline-setting.spec.tsx.snap Updates snapshots for new button/icon styles and colors.
libs/domains/service-terraform/feature/src/lib/hooks/use-terraform-available-versions/use-terraform-available-versions.ts Renames hook to plural and removes default export.
libs/domains/service-terraform/feature/src/index.ts Updates barrel exports (adds hook + inline setting export; removes prior export).
libs/domains/service-settings/feature/src/lib/terraform-configuration-settings/terraform-configuration-settings.ui.spec.tsx Updates mocks to use service-terraform feature hook export.
libs/domains/service-settings/feature/src/lib/terraform-configuration-settings/terraform-configuration-settings.tsx Uses Terraform hook + inline setting from service-terraform; updates UI and modal content structure.
libs/domains/service-settings/feature/src/lib/terraform-configuration-settings/terraform-configuration-settings.spec.ts Adds unit tests for dockerfile fragment helper utilities.
libs/domains/service-settings/feature/src/index.ts Exposes TerraformConfigurationSettings module from service-settings feature.
libs/domains/service-helm/feature/src/lib/values-override-yaml-setting/snapshots/values-override-yaml-setting.spec.tsx.snap Snapshot updates for empty-state color token changes.
libs/domains/service-helm/feature/src/lib/values-override-files-setting/snapshots/values-override-files-setting.spec.tsx.snap Snapshot updates for empty-state color token changes.
apps/console-v5/src/routes/_authenticated/.../settings/terraform-configuration.tsx Implements the new console-v5 Terraform configuration settings route with Suspense + form submission.
Comments suppressed due to low confidence (1)

libs/domains/service-settings/feature/src/lib/terraform-configuration-settings/terraform-configuration-settings.tsx:370

  • Modal trigger uses Link without the required to/params props. @qovery/shared/ui's Link wraps TanStack Router's Link (see LinkProps), so this will be a TypeScript error and is also semantically wrong for a non-navigation action. Use a button/Button for the trigger, or use Link with as="button" only if you also provide a valid to (navigation).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@RemiBonnet RemiBonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rmnbrd rmnbrd merged commit d33d798 into new-navigation Mar 26, 2026
11 checks passed
@rmnbrd rmnbrd deleted the feat/new-nav/terraform-configuration-settings branch March 26, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants