Skip to content

feat(service-avatar): reworking the service-avatar component for visual consistency#2543

Open
TheoGrandin74 wants to merge 4 commits intonew-navigationfrom
feat/new-nav/service-overview-icons
Open

feat(service-avatar): reworking the service-avatar component for visual consistency#2543
TheoGrandin74 wants to merge 4 commits intonew-navigationfrom
feat/new-nav/service-overview-icons

Conversation

@TheoGrandin74
Copy link
Contributor

@TheoGrandin74 TheoGrandin74 commented Mar 25, 2026

Summary

  • Fixed a bug with the "warning" icon size in the breadcrumb and service overview when the status of the service was "Unavailable"
  • Removed border and radius on the service icon in the service overview for design consistency + fixed a bug with the radius that was cutting some service icons like the standard application icon
  • Fixed a bug where rust/apache etc. icons were in black in dark mode because the css filter was not working

Before
image
image
image

After
image
image
image

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet
Copy link
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview d8a1b661-72ac-4c66-97c9-89bc61392356 test-prod-clone-prod
/qovery preview 8ba67a97-56f5-4655-9090-f29ba94c581f test-prod-clone
/qovery preview 28a82285-d324-4f14-a84a-a39d59316d1a staging-clone
/qovery preview 964984c5-fba6-4371-88d3-a5daf99642ab test-prod
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Make it work, make it right, make it fast

@TheoGrandin74 TheoGrandin74 changed the base branch from staging to new-navigation March 26, 2026 14:28
@TheoGrandin74 TheoGrandin74 changed the title Feat/new nav/service overview icons feat(service-avatar): reworking the service-avatar component for visual consistency Mar 26, 2026
@TheoGrandin74 TheoGrandin74 marked this pull request as ready for review March 26, 2026 15:20
@codecov
Copy link

codecov bot commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.78%. Comparing base (226ecee) to head (97e0001).
⚠️ Report is 19 commits behind head on new-navigation.

Files with missing lines Patch % Lines
...rvices/feature/src/lib/service-new/service-new.tsx 50.00% 0 Missing and 1 partial ⚠️
.../ui/src/lib/components/status-chip/status-chip.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           new-navigation    #2543      +/-   ##
==================================================
- Coverage           44.88%   44.78%   -0.10%     
==================================================
  Files                1112     1052      -60     
  Lines               22205    21045    -1160     
  Branches             6418     6174     -244     
==================================================
- Hits                 9967     9426     -541     
+ Misses              10426     9914     -512     
+ Partials             1812     1705     -107     
Flag Coverage Δ
unittests 44.78% <66.66%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@rmnbrd rmnbrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about adding 'dark:invert' to AWS and Bash icons?

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants