Skip to content

fix(deployment-logs): rendering history by service id not all from the environment#2544

Merged
RemiBonnet merged 10 commits intonew-navigationfrom
fix/new-nav/deployment-logs
Mar 27, 2026
Merged

fix(deployment-logs): rendering history by service id not all from the environment#2544
RemiBonnet merged 10 commits intonew-navigationfrom
fix/new-nav/deployment-logs

Conversation

@RemiBonnet
Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet commented Mar 26, 2026

Summary

  • Display the history related to the service id, you want to see the bug app
  • Improve loading state with deployment logs
  • Improve history switching to keep the dropdown visible
  • Display placeholder correctly with all states

Screenshots / Recordings

https://www.loom.com/share/6fe9cada1f70408d8a37f62da6d5f7df

Screenshot 2026-03-26 at 09 56 26 Screenshot 2026-03-26 at 11 37 15 Screenshot 2026-03-26 at 10 34 23

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet
Copy link
Copy Markdown
Member Author

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 15d69f24-9bc1-4a8d-80fe-d1bb1b2bcd00 New Navigation
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

There is no better time than now, better future does not exist

@RemiBonnet RemiBonnet marked this pull request as ready for review March 26, 2026 08:11
@RemiBonnet RemiBonnet force-pushed the fix/new-nav/deployment-logs branch from 3b9c6c1 to fc3ba91 Compare March 26, 2026 08:28
@RemiBonnet RemiBonnet added the V5 label Mar 26, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 28.57143% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.93%. Comparing base (e706962) to head (5d0ebf5).
⚠️ Report is 4 commits behind head on new-navigation.

Files with missing lines Patch % Lines
.../lib/list-deployment-logs/list-deployment-logs.tsx 32.69% 23 Missing and 12 partials ⚠️
...ployment-history/use-service-deployment-history.ts 0.00% 4 Missing ⚠️
.../lib/environment-pipeline/environment-pipeline.tsx 0.00% 3 Missing ⚠️
...t-logs-placeholder/deployment-logs-placeholder.tsx 40.00% 2 Missing and 1 partial ⚠️
...b/hooks/use-deployment-logs/use-deployment-logs.ts 0.00% 3 Missing ⚠️
...eployment-logs-content/deployment-logs-content.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           new-navigation    #2544      +/-   ##
==================================================
- Coverage           45.20%   44.93%   -0.28%     
==================================================
  Files                1113     1086      -27     
  Lines               22365    21831     -534     
  Branches             6554     6404     -150     
==================================================
- Hits                10111     9809     -302     
+ Misses              10403    10233     -170     
+ Partials             1851     1789      -62     
Flag Coverage Δ
unittests 44.93% <28.57%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RemiBonnet RemiBonnet force-pushed the fix/new-nav/deployment-logs branch from 590d2d8 to 3c6aa6a Compare March 26, 2026 15:52
@RemiBonnet RemiBonnet force-pushed the fix/new-nav/deployment-logs branch from 3f3e7ca to c843461 Compare March 26, 2026 17:31
Copy link
Copy Markdown
Contributor

@rmnbrd rmnbrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Looks good to me 💯

@RemiBonnet RemiBonnet merged commit 3303d7c into new-navigation Mar 27, 2026
11 checks passed
@RemiBonnet RemiBonnet deleted the fix/new-nav/deployment-logs branch March 27, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants