Skip to content

feat(service-access-modal): added "Access info" entry in the service actions#2548

Open
TheoGrandin74 wants to merge 2 commits intonew-navigationfrom
feat/new-nav/access-info
Open

feat(service-access-modal): added "Access info" entry in the service actions#2548
TheoGrandin74 wants to merge 2 commits intonew-navigationfrom
feat/new-nav/access-info

Conversation

@TheoGrandin74
Copy link
Contributor

Summary

  • Added in the service actions in the "more" button like the clusters
  • Tokenization added on the service-access-modal
image image

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet
Copy link
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 15d69f24-9bc1-4a8d-80fe-d1bb1b2bcd00 New Navigation
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

There is no better time than now, better future does not exist

@codecov
Copy link

codecov bot commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.68%. Comparing base (e706962) to head (21f6b48).
⚠️ Report is 2 commits behind head on new-navigation.

Files with missing lines Patch % Lines
...eature/src/lib/service-actions/service-actions.tsx 62.50% 3 Missing ⚠️
.../lib/service-access-modal/service-access-modal.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           new-navigation    #2548      +/-   ##
==================================================
- Coverage           45.20%   44.68%   -0.53%     
==================================================
  Files                1113     1054      -59     
  Lines               22365    21358    -1007     
  Branches             6554     6290     -264     
==================================================
- Hits                10111     9543     -568     
+ Misses              10403    10088     -315     
+ Partials             1851     1727     -124     
Flag Coverage Δ
unittests 44.68% <63.63%> (-0.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@RemiBonnet RemiBonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks Théo!

@rmnbrd rmnbrd added the V5 label Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants