Cache cross-zero unsupported-order-type set in brokerage models#9551
Merged
Conversation
TastytradeBrokerageModel and TradeStationBrokerageModel declared NotSupportedCrossZeroOrderTypes as an expression-bodied property, allocating a new constant HashSet on every CanSubmitOrder call (used per order in BrokerageExtensions.ValidateCrossZeroOrder). Make it a static readonly field, built once, matching the existing BrokerageExtensions.DefaultNotSupportedCrossZeroOrderTypes pattern. Set contents are unchanged, so cross-zero validation behavior is identical. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TastytradeBrokerageModelandTradeStationBrokerageModeldeclaredNotSupportedCrossZeroOrderTypesas an expression-bodied property (=> new HashSet<OrderType>(){...}), so a new constant set was allocated on everyCanSubmitOrdercall (each is used inBrokerageExtensions.ValidateCrossZeroOrderper order). Changed to astatic readonlyfield, built once.This matches the pattern already used in the same module —
BrokerageExtensions.DefaultNotSupportedCrossZeroOrderTypesis astatic readonlyfield.Correctness
The set contents are identical (fixed
OrderTypevalues), so cross-zero order validation behavior is unchanged — this only removes the per-call allocation.🤖 Generated with Claude Code