Skip to content

🌐 [translation-sync] Fix broken raw GitHub URLs for CSV data files#71

Closed
mmcky wants to merge 4 commits intomainfrom
translation-sync-2026-03-24T02-32-00-pr-491
Closed

🌐 [translation-sync] Fix broken raw GitHub URLs for CSV data files#71
mmcky wants to merge 4 commits intomainfrom
translation-sync-2026-03-24T02-32-00-pr-491

Conversation

@mmcky
Copy link
Contributor

@mmcky mmcky commented Mar 24, 2026

Automated Translation Sync

This PR contains automated translations from QuantEcon/lecture-python-programming.

Source PR

#491 - Fix broken raw GitHub URLs for CSV data files

Files Updated

  • ✏️ lectures/pandas.md
  • ✏️ .translate/state/pandas.md.yml
  • ✏️ lectures/python_advanced_features.md
  • ✏️ .translate/state/python_advanced_features.md.yml

Details

  • Source Language: en
  • Target Language: fa
  • Model: claude-sonnet-4-6

This PR was created automatically by the translation action.

@netlify
Copy link

netlify bot commented Mar 24, 2026

Deploy Preview for majestic-griffin-10b166 ready!

Name Link
🔨 Latest commit fdee500
🔍 Latest deploy log https://app.netlify.com/projects/majestic-griffin-10b166/deploys/69c1f7a67eb98e0007c8d311
😎 Deploy Preview https://deploy-preview-71--majestic-griffin-10b166.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Mar 24, 2026

❌ Translation Quality Review

Verdict: FAIL | Model: claude-sonnet-4-6 | Date: 2026-03-24


📝 Translation Quality

Criterion Score
Accuracy 7/10
Fluency 8/10
Terminology 8/10
Formatting 5/10
Overall 7.2/10

Summary: The translation quality for the changed sections is generally good in terms of accuracy, fluency, and terminology. However, there is a critical structural error in the python_advanced_features document: the entire Decorators and Descriptors section is duplicated — appearing both in its correct location and again where the Generators section (anchored by '(paf_generators)=') should begin. This duplication is a serious formatting/structural bug that must be fixed. The Generators section content does eventually appear but with the wrong anchor placement. Apart from this critical issue, the translation of the modified sections (Overview, DataFrames, Exercises for pandas; Overview, Iterables and Iterators, * and ** Operators, Decorators and Descriptors, Generators, Exercises for python_advanced_features) is competent and readable. Technical terminology is consistently and correctly translated throughout both documents, following the reference glossary (e.g., 'تولید ناخالص داخلی' for GDP, 'سری زمانی' for time series). Persian text reads naturally with appropriate academic register; sentence structures are well-adapted for RTL reading. Code blocks, LaTeX math, MyST directives, and figure references are all properly preserved without modification. The heading-map in the YAML frontmatter is correctly structured and comprehensive, covering all major sections. Inline code terms (Series, DataFrame, iterator, decorator, generator, etc.) are appropriately kept in English as is standard practice in Persian technical writing.

⚠️ Markdown Syntax Errors (CRITICAL)

  • 🔴 Duplicate section content: The entire '## Decorators and Descriptors' section (including all subsections: An Example, Enter Decorators, A Solution, How it Works, Decorators and Properties) appears TWICE in the python_advanced_features document. The section starting with '(paf_generators)=' anchor is followed by a duplicate '## Decoratorها و Descriptorها' section instead of the '## Generatorها' section.
  • 🔴 Structural error: The anchor '(paf_generators)=' which should precede '## Generatorها' is instead followed by a duplicate Decorators and Descriptors section, breaking the document structure.

Suggestions:

  • Iterables and Iterators section title: The heading-map maps to 'Iterableها و Iteratorها' but the rendered heading in the document body shows 'Iterableها و Iteratorها' — this is acceptable, but note the inconsistency between the heading-map entry 'Iterables and iterators' (lowercase i) vs the source '## Iterables and Iterators' (uppercase I).

  • Generators section (paf_generators anchor): The anchor '(paf_generators)=' is placed before a duplicate '## Decoratorها و Descriptorها' section instead of before '## Generatorها'. The entire Generators section content appears to have been inserted in place of the Decorators duplicate but instead the Decorators content was duplicated. The '## Generatorها' heading and its content (Generator Expressions, Generator Functions, Advantages of Iterators) appear later but the anchor placement is wrong.

  • Overview (python_advanced_features): 'مروری کلی' is used instead of 'مرور کلی' as used in the pandas section. While both are acceptable Persian, consistency across the document would be preferable — the heading-map for pandas uses 'مرور کلی' while python_advanced_features uses 'مروری کلی'.

  • Iterators in For Loops - translation of 'So now you know how this magical looking syntax works': rendered as 'بنابراین اکنون می‌دانید که این نحو جادویی چگونه کار می‌کند' — acceptable but 'نحو جادویی به نظر رسیده' would better preserve 'magical looking'.

  • Exercises (python_advanced_features): The exercise instruction 'which we assume that you've put in your current working directory' is translated as 'که فرض می‌کنیم آن را در دایرکتوری کاری فعلی خود قرار داده‌اید' — accurate and natural.


🔍 Diff Quality

Check Status
Scope Correct
Position Correct
Structure Preserved
Heading-map Correct
Overall 2.5/10

Summary: The translation sync has critical structural failures: the python_advanced_features.md target duplicates the entire Decorators and Descriptors section where the Generators section should be, the heading-map uses stale/incorrect heading keys that don't match the updated source headings, and a URL change in pandas.md was not propagated to the target.

Issues:

  • python_advanced_features.md target 'After' contains a massively duplicated 'Decorators and Descriptors' section: after the Generators anchor (paf_generators)=, the entire Decorators and Descriptors section (including all subsections, code cells, and content) is repeated verbatim instead of the Generators section content appearing there. This is a critical structural error.
  • The heading-map in python_advanced_features.md 'After' is incorrect: it still maps old English source headings (e.g., 'Iterables and iterators', '* and ** operators', 'Decorators and descriptors', 'Generators', etc. with lowercase variants) instead of updating to the new English headings from the source 'After' (e.g., 'Iterables and Iterators', '* and ** Operators', 'Decorators and Descriptors', 'Generator Expressions', 'Generator Functions', 'Advantages of Iterators'). The source changed heading capitalizations throughout.
  • The heading-map also incorrectly maps 'Type hints', 'Type hints::Basic syntax', 'Type hints::Common types' to Decorator/Descriptor translations, which is wrong — the 'Type hints' section was removed from the source 'After', so these entries should be removed, not remapped.
  • The heading-map adds 'More Language Features: ویژگی‌های بیشتر زبان' which is the h1 title — this is unusual and may be incorrect since the h1 is handled separately from section headings.
  • pandas.md heading-map 'After' adds '{index}\Pandas <single: Pandas>`': '{index}`Pandas <single: Pandas>`'` which maps the h1 title to itself (untranslated) — this is suspicious and likely incorrect since h1 titles are not typically in the heading-map.
  • The source 'After' for python_advanced_features.md removed the 'Type hints' section entirely, but the target 'After' heading-map still contains 'Type hints' related entries (remapped incorrectly to decorator/descriptor translations).
  • The url change in pandas.md (from 'master/source/_static' to 'main/lectures/_static') was NOT reflected in the target — the target still uses the old URL. This is a missed content sync.

This review was generated automatically by action-translation review mode.

@github-actions
Copy link

@github-actions github-actions bot temporarily deployed to pull request March 24, 2026 02:37 Inactive
@mmcky mmcky closed this Mar 24, 2026
@mmcky mmcky deleted the translation-sync-2026-03-24T02-32-00-pr-491 branch March 24, 2026 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant