Port the numpy.md edits the resync regeneration dropped (seed docstring, qe.Timer) - #38
Merged
Conversation
… dropped The batch's original sync PR here (#30) was closed unmerged and its regeneration (#34) silently omitted numpy.md, so the two #595 edits never arrived: the DiscreteRV seed docstring (kept in English verbatim, as this lecture's docstrings are) and the tic/toc sentence, now le gestionnaire de contexte qe.Timer(). Hand-ported rather than regenerated because numpy.md carries Emile's native review (#24) that a whole-file resync would discard. State advances to the batch commit d35eb831. Measurement and ledger: QuantEcon/action-translation#276. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR hand-ports two previously dropped edits into the French numpy.md lecture to match the upstream cleanup batch, while preserving the native French review of the file and updating translation sync state.
Changes:
- Updates
DiscreteRV.__init__docstring to document theseedargument (English docstring kept, per project convention). - Updates the exercise text to reference the
qe.Timer()context manager (matching the code examples that usewith qe.Timer(...)). - Advances
.translate/state/numpy.md.ymlto the upstreamsource-shaand updates the sync timestamp so translation status no longer flags the file as pending.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lectures/numpy.md | Ports upstream docstring + exercise wording change (tic/toc → qe.Timer()) |
| .translate/state/numpy.md.yml | Updates source-sha and synced-at to reflect the upstream batch commit |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| **Partie 2** : Passez à la reproduction du résultat de l'opération de broadcasting suivante. Parallèlement, comparez les vitesses du broadcasting et de la boucle `for` que vous implémentez. | ||
|
|
||
| Pour cette partie de l'exercice, vous pouvez utiliser les fonctions `tic`/`toc` de la bibliothèque `quantecon` pour chronométrer l'exécution. | ||
| Pour cette partie de l'exercice, vous pouvez utiliser le gestionnaire de contexte `qe.Timer()` de la bibliothèque `quantecon` pour chronométrer l'exécution. |
📖 Netlify Preview Ready!Preview URL: https://pr-38--verdant-toffee-3261a8.netlify.app Commit: 📚 Changed LecturesBuild Info
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hand-port of the two
numpy.mdedits from the source cleanup batch, which never arrived here: the batch's original sync PR (#30) was closed unmerged, and the regeneration (#34) silently omitted the file — the per-file drop is documented in the measured ledger in QuantEcon/action-translation#276.The two edits mirror the source hunks exactly: the
DiscreteRVseed docstring is added verbatim in English (this lecture keeps docstrings in English), and the exercise sentence moves from "les fonctionstic/toc" to "le gestionnaire de contexteqe.Timer()" — the minimal substitution inside the reviewed sentence, using the standard French Python-docs term per the fr terminology rule..translate/state/numpy.md.ymladvancessource-shato the batch commit (d35eb831, verified today as the source's last-touch commit for this file), sotranslate statusstops flagging the lecture as pending;model/mode/tool-versionare left as the seed translation's provenance.Ported by hand rather than regenerated deliberately: numpy.md is one of the two natively-reviewed French lectures (#24, Emile), and a whole-file resync would discard that review.
🤖 Generated with Claude Code