chore: Update copier template to v0.5.1#297
Conversation
24b5037 to
45b69ce
Compare
| name = "dataframely" | ||
|
|
||
| [package.build] | ||
| backend = { name = "pixi-build-python", git = "https://github.com/pavelzw/pixi", branch = "abi3", subdirectory = "crates/pixi_build_python" } |
There was a problem hiding this comment.
depends on prefix-dev/pixi#5751
There was a problem hiding this comment.
Pull request overview
Updates the repository to copier template v0.5.1, modernizing the project’s Pixi/build and linting setup to match the upstream template.
Changes:
- Switch linting workflow from pre-commit config to Lefthook-driven
pixi run lint. - Introduce Pixi “package build” (pixi-build) configuration and adjust build-system metadata.
- Update various GitHub workflows/dependabot/copier metadata to the new template version.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
pyproject.toml |
Adds hatchling to build requirements; reorders/clarifies project metadata fields. |
pixi.toml |
Adds pixi-build package config, updates env/features/tasks (notably lint via lefthook), adjusts build deps/tasks. |
AGENTS.md |
Documents expected dev workflow (pixi lock, pixi run, pixi run lint). |
.pre-commit-config.yaml |
Removed (replaced by lefthook configuration). |
.lefthook.yaml |
New lefthook pipeline running ruff/mypy/prettier/taplo/etc within pixi. |
.github/workflows/scorecard.yml |
Template update attempted, but currently contains unresolved merge conflict markers. |
.github/workflows/ci.yml |
Template update attempted, but currently contains unresolved merge conflict markers and outdated steps. |
.github/workflows/build.yml |
Template update attempted, but currently contains unresolved merge conflict markers; still references a removed pixi env. |
.github/dependabot.yml |
Adds dependabot cooldown configuration. |
.copier-answers.yml |
Bumps copier template commit to v0.5.1. |
.claude/CLAUDE.md |
Adds pointer to AGENTS.md. |
| - name: Install repository | ||
| run: pixi run -e ${{ matrix.environment }} postinstall | ||
| ||||||| last update | ||
| - name: Install repository | ||
| run: pixi run -e ${{ matrix.environment }} postinstall |
There was a problem hiding this comment.
pixi run -e ${{ matrix.environment }} postinstall will fail because pixi.toml no longer defines a postinstall task. Either reintroduce a postinstall task or remove this step and rely on pixi install / the environment setup to build/install the package.
| <<<<<<< before updating | ||
| uses: prefix-dev/setup-pixi@a0af7a228712d6121d37aba47adf55c1332c9c2e # v0.9.4 | ||
| with: | ||
| environments: build | ||
| - name: Set version | ||
| run: pixi run -e build set-version | ||
| ||||||| last update | ||
| uses: prefix-dev/setup-pixi@19eac09b398e3d0c747adc7921926a6d802df4da # v0.8.8 | ||
| with: | ||
| environments: build | ||
| ======= | ||
| uses: prefix-dev/setup-pixi@a0af7a228712d6121d37aba47adf55c1332c9c2e # v0.9.4 | ||
| - name: Derive version | ||
| id: version | ||
| if: startsWith(github.ref, 'refs/tags/') | ||
| shell: bash | ||
| run: echo "version=$(git describe --tags --abbrev=0 | sed 's/^v//')" >> $GITHUB_OUTPUT | ||
| - name: Replace version | ||
| if: startsWith(github.ref, 'refs/tags/') | ||
| run: | | ||
| sed -i -e "s/0.0.0/${STEPS_VERSION_OUTPUTS_VERSION}/g" pyproject.toml | ||
| env: | ||
| STEPS_VERSION_OUTPUTS_VERSION: ${{ steps.version.outputs.version }} | ||
| >>>>>>> after updating |
There was a problem hiding this comment.
This workflow contains unresolved merge conflict markers in the pixi setup/versioning section. Resolve the conflict and ensure the resulting workflow still sets up pixi (with the intended environment) before running any pixi run ... steps.
| <<<<<<< before updating | ||
| - uses: actions/download-artifact@70fc10c6e5e1ce46ad2ea6f2b72d43f7d47b13c3 # v8.0.0 | ||
| ||||||| last update | ||
| - uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 | ||
| ======= | ||
| - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 | ||
| >>>>>>> after updating |
There was a problem hiding this comment.
This release job step contains unresolved merge conflict markers around the actions/download-artifact version pin. Resolve the conflict and keep only one uses: line.
| set-version = "sed -i \"s/0.0.0/$(python -m setuptools_scm)/\" pyproject.toml" | ||
|
|
||
| [feature.lint.dependencies] | ||
| docformatter = "*" | ||
| lefthook = "*" | ||
| insert-license-header = "*" |
There was a problem hiding this comment.
set-version runs python -m setuptools_scm, but setuptools-scm is no longer listed in the feature.build.dependencies. This will break pixi run ... set-version in CI; either add setuptools-scm back or update set-version to use the new versioning tool/dependency you intend (e.g., version).
| <<<<<<< before updating | ||
| uses: github/codeql-action/upload-sarif@89a39a4e59826350b863aa6b6252a07ad50cf83e # v3.29.5 | ||
| ||||||| last update | ||
| uses: github/codeql-action/upload-sarif@ff0a06e83cb2de871e5a09832bc6a81e7276941f # v3.28.18 | ||
| ======= | ||
| uses: github/codeql-action/upload-sarif@0d579ffd059c29b07949a3cce3983f0780820c98 # v4.32.6 | ||
| >>>>>>> after updating |
There was a problem hiding this comment.
This workflow contains unresolved merge conflict markers (e.g., <<<<<<<, |||||||, =======, >>>>>>>). GitHub Actions will treat this as invalid YAML; resolve the conflict and keep a single uses: github/codeql-action/upload-sarif@... entry.
| <<<<<<< before updating | |
| uses: github/codeql-action/upload-sarif@89a39a4e59826350b863aa6b6252a07ad50cf83e # v3.29.5 | |
| ||||||| last update | |
| uses: github/codeql-action/upload-sarif@ff0a06e83cb2de871e5a09832bc6a81e7276941f # v3.28.18 | |
| ======= | |
| uses: github/codeql-action/upload-sarif@0d579ffd059c29b07949a3cce3983f0780820c98 # v4.32.6 | |
| >>>>>>> after updating | |
| uses: github/codeql-action/upload-sarif@0d579ffd059c29b07949a3cce3983f0780820c98 # v4.32.6 |
| <<<<<<< before updating | ||
| pre-commit-checks: | ||
| name: Pre-commit Checks | ||
| ||||||| last update | ||
| pre-commit: | ||
| ======= | ||
| lint: | ||
| name: Lint | ||
| >>>>>>> after updating |
There was a problem hiding this comment.
This workflow still contains unresolved merge conflict markers (<<<<<<<, |||||||, =======, >>>>>>>) around the lint job definition. The file is invalid YAML until the conflict is resolved and only one job name/structure is kept.
| <<<<<<< before updating | ||
| run: pixi run -e build build-sdist | ||
| ||||||| last update | ||
| run: pixi run -e build build-wheel | ||
| - name: Check package | ||
| run: pixi run check-wheel | ||
| ======= | ||
| run: pixi run build-wheel | ||
| - name: Check package | ||
| run: pixi run check-wheel | ||
| >>>>>>> after updating |
There was a problem hiding this comment.
This section still has unresolved merge conflict markers. Until these are removed, the workflow is invalid YAML and won’t run.
| uses: prefix-dev/setup-pixi@a0af7a228712d6121d37aba47adf55c1332c9c2e # v0.9.4 | ||
| with: | ||
| environments: build | ||
| - name: Set version | ||
| run: pixi run -e build set-version |
There was a problem hiding this comment.
The workflow expects a build pixi environment (environments: build / pixi run -e build ...), but pixi.toml no longer defines build under [environments]. Add that environment back or switch these steps to an existing environment that includes the build feature/tasks.
| name = "dataframely" | ||
|
|
||
| [package.build] | ||
| backend = { name = "pixi-build-python", git = "https://github.com/pavelzw/pixi", branch = "abi3", subdirectory = "crates/pixi_build_python" } |
There was a problem hiding this comment.
[package.build].backend is pulled from a Git branch (branch = "abi3"). For reproducible builds/locks, consider pinning this to an immutable ref (tag or commit SHA) instead of a moving branch.
| backend = { name = "pixi-build-python", git = "https://github.com/pavelzw/pixi", branch = "abi3", subdirectory = "crates/pixi_build_python" } | |
| backend = { name = "pixi-build-python", git = "https://github.com/pavelzw/pixi", rev = "0123456789abcdef0123456789abcdef01234567", subdirectory = "crates/pixi_build_python" } |
This PR was automatically generated. Please check for left over merge conflicts before merging
Changelog:
v0.5.0
What's Changed
zizmorpre commit hook by ManuelLerchnerQC in feat: Addzizmorpre commit hook copier-template-python-open-source#132lintenvironment by pavelzw in Migrate to lefthook, removelintenvironment copier-template-python-open-source#133New Contributors
github/codeql-action/upload-sarifversion comment and update action copier-template-python-open-source#131Full Changelog: Quantco/copier-template-python-open-source@v0.4.1...v0.5.0
v0.5.1
What's Changed
Full Changelog: Quantco/copier-template-python-open-source@v0.5.0...v0.5.1