Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the intra-pod all-to-all preset to execute all A2A groups within a pod concurrently (single RunTransfers per pod) and enhances the output to show explicit A2A group membership and a rank-grouped display layout.
Changes:
- Build transfers for all groups in a pod and execute them together to enable concurrent cross-group traffic.
- Print A2A group membership (rank/GPU) in the output.
- Reformat the per-group bandwidth table to group columns by MPI rank (with multiple GPUs per rank column).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+182
to
+184
| groupTransferBase[group] = (int)podTransfers.size(); | ||
| groupReIndexes[group].assign(groupSize, std::vector<int>(groupSize, -1)); | ||
| std::vector<std::vector<int>>& groupReIndex = groupReIndexes[group]; |
Comment on lines
+274
to
+281
| std::vector<int> order(groupSize); | ||
| for (int i = 0; i < groupSize; i++) order[i] = i; | ||
| std::sort(order.begin(), order.end(), [&](int a, int b) { | ||
| MemDevice const& da = devices[groupBase + a]; | ||
| MemDevice const& db = devices[groupBase + b]; | ||
| if (da.memRank != db.memRank) return da.memRank < db.memRank; | ||
| return da.memIndex < db.memIndex; | ||
| }); |
| }); | ||
| for (size_t si = 0; si < ord.size(); si++) { | ||
| MemDevice const& d = devices[gb + ord[si]]; | ||
| Utils::Print("%s R%d:G%d", si ? "," : "", d.memRank, d.memIndex); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Tested on 8 devices (2 node with 4 GPU each launched by MPI) in a single pod, multi-pod scenario yet investigated
Test Result
Example Output from a 2 x 4G cluster
Default (1 Group of size 8 in natural order)
2 Groups with Stride 2
Submission Checklist